Make the font size more robust against fickle browser values. #1956
Conversation
Also change the line-height multiplier to 1.3, which is closer to what the CSS is (I think it is 1.21 something.) Thanks to @williamstein and @haraldschilly for bringing this to our attention: sagemathinc/cocalc#1262 We also re-enable auto scrolling for Firefox, since this might have been the issue.
|
@williamstein, @haraldschilly - can you check to see if this change fixes your issue? |
|
+1 to doing this. If this code works at all, it'll fix our issue, since on Firefox (when using fromJSON), we were getting fontSize is undefined tracebacks. I'm not sure what the workflow would be for testing this properly... This issue on our side sagemathinc/cocalc#1343 -- it would be nice if somebody could comment on sagemathinc/cocalc#1343 when this PR goes into Jupyter master. |
Is it easy to hand-edit the javascript file with this change to check it? The relevant file should be /static/notebook/js/built/1.main.min.js if you're using notebook master. Search for |
|
Thanks! I imagine we'll get feedback and tweaks related to other things in 4.3, so we can do a 4.3.1 with the inevitable polish (this included) in a week or two. |
…ser values. Also change the line-height multiplier to 1.3, which is closer to what the CSS is (I think it is 1.21 something.) Thanks to williamstein and haraldschilly for bringing this to our attention: sagemathinc/cocalc#1262 We also re-enable auto scrolling for Firefox, since this might have been the issue. Signed-off-by: Min RK <benjaminrk@gmail.com>
4 participants
Also change the line-height multiplier to 1.3, which is closer to what the CSS is (I think it is 1.21 something.)
Thanks to @williamstein and @haraldschilly for bringing this to our attention: sagemathinc/cocalc#1262
We also re-enable auto scrolling for Firefox, since this might have been the issue.