Skip to content

Fix jitter caused by rounding height. #2688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 26, 2017
Merged

Fix jitter caused by rounding height. #2688

merged 1 commit into from
Jul 26, 2017

Conversation

jasongrout
Copy link
Member

@jasongrout jasongrout commented Jul 26, 2017 •
edited
Loading

Fixes #2668.

Before height rounding fix (notice that the cell below the interact jitters its height):
jitter

After:
jitterfixed

@jasongrout jasongrout added this to the 5.1 milestone Jul 26, 2017
@jasongrout
Copy link
Member Author

CC @gnestor

@gnestor
Copy link
Contributor

gnestor commented Jul 26, 2017

Thanks @jasongrout!

@gnestor gnestor merged commit a916035 into jupyter:master Jul 26, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@blink1073 blink1073 blink1073 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug component:Notebook status:resolved-locked tag:Design and UX

Projects

None yet

Milestone

5.1

Development

Successfully merging this pull request may close these issues.

Output area height is rounded when fixing height on clear

4 participants

@jasongrout @gnestor @blink1073 @takluyver