--all flag for jupyter nbextension disable #2724
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minrk
reviewed
Aug 4, 2017
| def toggle_nbextension_python(self, module): | ||
| if self.all_config_locations: | ||
| for config_dir in jupyter_config_path(): | ||
| disable_nbextension_python(self.section, module, |
There was a problem hiding this comment.
We should make sure this does:
if enabled at this level:
set enabled = None # (not False. None pops config, False stores a value)
else:
do nothingSo that it doesn't try to write any configuration files where there wasn't any to start with.
This was referenced Aug 4, 2017
|
Closing in favour of #2729 . |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2149, #2715.
This roughly implements option 2 from Min's comment, which is what I'd expect from
--all.The alternative is to disable in only the first location where it is found enabled. I might even make that the default behaviour if we do that.