Add "all" flag to nbextension and serverextension commands #2715
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@takluyver @minrk I'm not sure whether this is the right approach... As opposed to "check every level where the enable config is defined", this is just adding an "all" trait to the top-level class and some logic to the
start
method that will setuser
andsys_prefix
toTrue
if the all flag is enabled. This requires all subclass instances to callsuper(CommandInstance, self).start()
.Closes #2149