stat symlink to determine access #3624
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minrk
reviewed
May 22, 2018
| return True | ||
|
|
||
| if stat_res is None: | ||
| if stat_res is None or stat.S_ISLNK(stat_res.st_mode): |
There was a problem hiding this comment.
This should already be the stat_res for this path, at least according to the docstring. Do you mean to check ISLNK at another location, perhaps after calling realpath?
There was a problem hiding this comment.
In this case the docstring is wrong because _dir_model() passes the result of an lstat() call. To check if we are allowed to read the directory, we have to follow the symlink, though. That's why I called stat() again on the path.
There seems to be a good reason for using lstat() in _dir_model() (#2574).
There was a problem hiding this comment.
Gotcha, I remember that now. Thanks!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A symlink pointing to a directory where you have no access permissions will result in a 404 for the entire directory containing the symlink.
This could also be fixed in FileContentsManager._dir_model() but I don't know what the implications on Windows would be.