Skip to content

stat symlink to determine access #3624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2018
Merged

stat symlink to determine access #3624

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion notebook/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ def is_file_hidden_posix(abs_path, stat_res=None):
if os.path.basename(abs_path).startswith('.'):
return True

if stat_res is None:
if stat_res is None or stat.S_ISLNK(stat_res.st_mode):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should already be the stat_res for this path, at least according to the docstring. Do you mean to check ISLNK at another location, perhaps after calling realpath?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case the docstring is wrong because _dir_model() passes the result of an lstat() call. To check if we are allowed to read the directory, we have to follow the symlink, though. That's why I called stat() again on the path.
There seems to be a good reason for using lstat() in _dir_model() (#2574).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha, I remember that now. Thanks!

try:
stat_res = os.stat(abs_path)
except OSError as e:
Expand Down