Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title new buttons with label if action undefined #5676

Merged
merged 1 commit into from
Aug 13, 2020
Merged

Conversation

rgbkrk
Copy link
Member

@rgbkrk rgbkrk commented Aug 12, 2020

On a recent release of the notebook js that included #5107, some extensions would fail because they either did not have an action or their action.help was not part of the i18n lookup (most extensions). This provides a fallback to el.label.

Copy link
Member

@Zsailer Zsailer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, @rgbkrk.

(Edit: my autocomplete put @kevin-bates on here. Sorry about that! 😆 )

@rgbkrk
Copy link
Member Author

rgbkrk commented Aug 12, 2020

@drillan -- when people use https://github.com/drillan/jupyter-black with a more recent Jupyter release they run into this error:

image

Since this would affect more than just the black extension, I went after fixing it in Jupyter directly. Just a heads up in case you get any issues!

@rgbkrk
Copy link
Member Author

rgbkrk commented Aug 12, 2020

@Zsailer @kevin-bates How should extension developers adapt to i18n?

@kevin-bates
Copy link
Member

Shoot - I just cut NB 6.1.2 this morning! Since this was introduced in 6.1, this is a regression and worthy of a patch. Seems like the previous change also intended for el.label to be the fallback but didn't anticipate a null action.

How should extension developers adapt to i18n?

@rgbkrk - Sorry, I have no idea. Seems like a question for when this was first developed, but the i18n README doesn't touch on that.

@rgbkrk
Copy link
Member Author

rgbkrk commented Aug 12, 2020

Shoot - I just cut NB 6.1.2 this morning!

Love to keep those patches coming. 😄

@kevin-bates kevin-bates merged commit cd9d0c9 into master Aug 13, 2020
@kevin-bates
Copy link
Member

@rgbkrk et al - Notebook 6.1.3 is available on pypi

@rgbkrk rgbkrk deleted the title-by-label branch August 13, 2020 21:28
@rgbkrk
Copy link
Member Author

rgbkrk commented Aug 13, 2020

Thank you Kevin!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants