Title new buttons with label if action undefined #5676
Conversation
There was a problem hiding this comment.
LGTM! Thanks, @rgbkrk.
(Edit: my autocomplete put @kevin-bates on here. Sorry about that! 😆 )
|
@drillan -- when people use https://github.com/drillan/jupyter-black with a more recent Jupyter release they run into this error:
Since this would affect more than just the black extension, I went after fixing it in Jupyter directly. Just a heads up in case you get any issues! |
|
@Zsailer @kevin-bates How should extension developers adapt to i18n? |
|
Shoot - I just cut NB 6.1.2 this morning! Since this was introduced in 6.1, this is a regression and worthy of a patch. Seems like the previous change also intended for el.label to be the fallback but didn't anticipate a null action.
@rgbkrk - Sorry, I have no idea. Seems like a question for when this was first developed, but the i18n README doesn't touch on that. |
Love to keep those patches coming. 😄 |
|
@rgbkrk et al - Notebook 6.1.3 is available on pypi |
|
Thank you Kevin! |
On a recent release of the notebook js that included #5107, some extensions would fail because they either did not have an
actionor theiraction.helpwas not part of the i18n lookup (most extensions). This provides a fallback toel.label.