add JS lint workflow #230
Merged
add JS lint workflow #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonWeill
added
maintenance
|
@JasonWeill lint: lerna run lint --stream --scope \"@jupyter-ai/core\" |
|
Should we add |
jupyter_ai is the only package with TS code. I think cookiecutter is not currently usable as is for providers. |
|
When running at the top level, it seems like code in the |
3coins
reviewed
Jun 20, 2023
dlqqq
force-pushed
the
jupyter-ai-lint-errors
branch
from
92dd0bf
to
f328a82
Compare
dlqqq
force-pushed
the
jupyter-ai-lint-errors
branch
from
f328a82
to
53c8bee
Compare
dlqqq
force-pushed
the
jupyter-ai-lint-errors
branch
from
53c8bee
to
284f602
Compare
|
Looks good! Thanks @dlqqq for your revisions. (I can't give a ship-it to this PR, since I'm still listed as the author.) |
Merged
dbelgrod
pushed a commit
to dbelgrod/jupyter-ai
that referenced
this pull request
Jun 10, 2024
* Fixes error and omission in config files * Changes after running jlpm lint once * Modifies eslint config * Ignores dotfiles * Fix lint errors * Fixes or ignores eslint warnings * Add new workflow * Fix error in config * Runs linting only on Linux * Uses standard GitHub action for setup-node * Force yarn used for caching * Simplify test config * Adds reopen trigger * fix lint workflow --------- Co-authored-by: David L. Qiu <david@qiu.dev>
Marchlak
pushed a commit
to Marchlak/jupyter-ai
that referenced
this pull request
Oct 28, 2024
* Fixes error and omission in config files * Changes after running jlpm lint once * Modifies eslint config * Ignores dotfiles * Fix lint errors * Fixes or ignores eslint warnings * Add new workflow * Fix error in config * Runs linting only on Linux * Uses standard GitHub action for setup-node * Force yarn used for caching * Simplify test config * Adds reopen trigger * fix lint workflow --------- Co-authored-by: David L. Qiu <david@qiu.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran
jlpm lintinsidepackages/jupyter-ai. This change fixes or suppresses all lint errors found.Adds a new GitHub action to run
lerna run linton every pull request in this package. Note that the action doesn't run on this pull request.This is prep work for #201, which should run
linton all PRs.