Restyles model names in Markdown to avoid wrapping model names #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krassowski
reviewed
Jan 31, 2024
|
Here's what the table looks like as a list: 
I had avoided using a list earlier because, especially on extra-wide screens, the |
|
List looks clearer to me. To be honest when working with notebooks in lab on 4k I usually have two notebooks or notebook and editor open side by side. In Jupyter Notebook there is max width I believe and the content gets centered so again the white space is not a practical concern. |
JasonWeill
force-pushed
the
nonbreaking-hyphens
branch
from
7400f3c
to
c9b64b4
Compare
|
@meeseeksdev please backport to 1.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyter-ai
that referenced
this pull request
Feb 1, 2024
… wrapping model names
JasonWeill
added a commit
that referenced
this pull request
Feb 1, 2024
…model names (#615) Co-authored-by: Jason Weill <93281816+JasonWeill@users.noreply.github.com>
dbelgrod
pushed a commit
to dbelgrod/jupyter-ai
that referenced
this pull request
Jun 10, 2024
…erlab#606) * Restyles model names in Markdown to avoid wrapping model names * Renders models in an unordered list in a cell
Marchlak
pushed a commit
to Marchlak/jupyter-ai
that referenced
this pull request
Oct 28, 2024
…erlab#606) * Restyles model names in Markdown to avoid wrapping model names * Renders models in an unordered list in a cell
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #604.
Before, some model names would break across lines:
Now, model names may not wrap across lines:
With the exception of the help text for Hugging Face, we now use a CSS rule to set font family and wrapping style. When multiple models' names are present, I think this makes a long list of models easier to read than before.