Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle small tabs overflowing and preserve the border bridging for the active tab #6548

Merged
merged 1 commit into from
Jun 12, 2019
Merged

Handle small tabs overflowing and preserve the border bridging for the active tab #6548

merged 1 commit into from
Jun 12, 2019

Commits on Jun 12, 2019

  1. Handle small tabs overflowing and preserve the border bridging for th… 

    …e active tab

Fixes jupyterlab#6532
Reverts jupyterlab#6526
Reverts jupyterlab#6492


jupyterlab#3986 is now an issue again, but setting the tab min width to 0px (instead of 36px) and setting the tab overflow to hidden makes it less likely to appear in practice (i.e., the tabs need to be much denser now to overflow into the splitter). Setting the tab overflow to hidden also makes the close icon for tabs not overlap the next tab, which was very confusing.

I think this is the best compromise at this point.

I also experimented unsuccessfully with setting the z-index of the splitter handle in an attempt to get it to be on top of overflowing tabs.
    @jasongrout
    jasongrout committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    9243140 View commit details
    Browse the repository at this point in the history