SmallRye Reactive Messaging In Memory connector

[kabir]

No description provided.

[github-actions]

Dependency Tree Analyzer Output:

New Dependencies:

• org.wildfly:wildfly-microprofile-reactive-messaging-inmemory:jar:29.0.0.Beta1-SNAPSHOT:compile

CC @wildfly/prod

[kabir]

We should try to find another way, and use the original artifact directly in the module.xml. Or it makes it hard to monitor for security vulnerabilities etc.

I understand the reason is to add a beans.xml. I think there is a way, but need to look into it. Hopefully this module will not be needed.

[kabir]

OK, so it seems that there is another way :-)
Under galleon-pack/galleon-shared/src/main/resources/packages, create a folder called the same as the module, i.e. io.smallrye.reactive.messaging.connector.inmemory. In there adjust the instructions in https://docs.wildfly.org/galleon-plugins/#_defining_packages to add a META-INF/beans.xml.

[kuhhpid]

I tried this method but in the end I can only add files to the root of the server, but the beans.xml is required in the /modules/system/layers/base/io/smallrye/reactive/messaging/connector/inmemory/main/smallrye-reactive-messaging-in-memory-4.6.0.jar I am not sure how to do the trick with the mentioned instructions.

[kabir]

@kuhhpid If you have some WIP, let me know the branch and I can see if I can figure out that part

[kuhhpid]

@kabir Here is the branch with the changes to use the ja directly https://github.com/kuhhpid/wildfly-smallrye-in-memory/tree/direct-jar-usage

[kabir]

Although, this will need some changes, it will still be relevant once you add the in memory connector dependency 'properly' :-)

Basically, the only places we should use version properties is in the section of a parent pom or a BOM. In this case this will be boms/common-expansion/pom.xml (look for where io.smallrye.reactive:smallrye-reactive-messaging-kafka is added). Then we can refer to that in the rest of the project without a version.

Then it will also need adding in these files

% git grep "<artifactId>smallrye-reactive-messaging-kafka</artifactId>"
boms/common-expansion/pom.xml:                <artifactId>smallrye-reactive-messaging-kafka</artifactId>
galleon-pack/galleon-shared/pom.xml:            <artifactId>smallrye-reactive-messaging-kafka</artifactId>
galleon-pack/galleon-shared/src/main/resources/license/licenses.xml:            <artifactId>smallrye-reactive-messaging-kafka</artifactId>

and should be automatically picked up when the module.xml is created

[kabir]

With the other stuff I have mentioned, adjust this to be the smallrye in memory connector maven artifact

[kuhhpid]

This is fixed also in the new branch: https://github.com/kuhhpid/wildfly-smallrye-in-memory/tree/direct-jar-usage