Skip to content

Conversation

yeikel
Copy link
Collaborator

@yeikel yeikel commented Sep 23, 2025

What changes did you make? (Give an overview)

Upgrades lombok to the latest version (1.18.42) to improve support for Java 25+

See projectlombok/lombok#3859

Is there anything you'd like reviewers to focus on?

This work is part of #1349

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

A picture of a cute animal (not mandatory but encouraged)

28138502587_a0a020ae9a_k

@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Sep 23, 2025
@yeikel yeikel marked this pull request as ready for review September 23, 2025 05:30
@yeikel yeikel requested a review from a team as a code owner September 23, 2025 05:30
@Haarolean
Copy link
Member

Feel free to combine lib bumps in a single PR tho

@Haarolean Haarolean added scope/backend Related to backend changes type/dependencies A pull request/issue dedicated to updating the dependency(-ies) and removed status/triage/manual Manual triage in progress labels Sep 23, 2025
@Haarolean Haarolean added this to the 1.4 milestone Sep 23, 2025
@Haarolean Haarolean enabled auto-merge (squash) September 23, 2025 11:14
@yeikel
Copy link
Collaborator Author

yeikel commented Sep 23, 2025

Feel free to combine lib bumps in a single PR tho

Sure, thanks! Apologies if it caused noise

The reason I sent them separately is because they are easier to reason about and revert if needed. I try to avoid bundles as much as possible for that reason

@Haarolean Haarolean merged commit f4c6692 into kafbat:main Sep 23, 2025
13 of 14 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Release 1.4 Sep 23, 2025
@yeikel yeikel deleted the lambok branch September 23, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope/backend Related to backend changes status/triage/completed Automatic triage completed type/dependencies A pull request/issue dedicated to updating the dependency(-ies)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants