Skip to content

Commit fff7b0a

Browse files
committed
feat: enhance scaffold logic for shared libraries and update Python models with default values
Signed-off-by: kaifcoder <kaifmohd2014@gmail.com>
1 parent 68fd895 commit fff7b0a

File tree

3 files changed

+7
-11
lines changed

3 files changed

+7
-11
lines changed

bin/lib/scaffold.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1362,8 +1362,9 @@ export async function scaffoldSharedLibrary(projectDir, { type, name }, options
13621362
if (file.isFile()) {
13631363
let content = await fs.readFile(path.join(templateDir, file.name), 'utf-8');
13641364

1365-
// Replace template variables
1366-
content = content.replace(/\{\{name\}\}/g, name);
1365+
// Replace template variables with appropriate naming conventions
1366+
const packageName = type === 'go' ? name.replace(/-/g, '_') : name;
1367+
content = content.replace(/\{\{name\}\}/g, packageName);
13671368

13681369
// Handle special file name replacements
13691370
let targetFileName = file.name;

package-lock.json

Lines changed: 0 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

templates/libs/python/models.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@ def __post_init__(self):
2424
@dataclass
2525
class ServiceHealth(BaseModel):
2626
"""Model for service health status."""
27-
service_name: str
28-
status: str # "healthy", "degraded", "unhealthy"
27+
service_name: str = ""
28+
status: str = "unknown" # "healthy", "degraded", "unhealthy"
2929
version: Optional[str] = None
3030
uptime: Optional[float] = None
3131
last_check: Optional[datetime.datetime] = None
@@ -34,6 +34,6 @@ class ServiceHealth(BaseModel):
3434
@dataclass
3535
class ErrorResponse(BaseModel):
3636
"""Model for standardized error responses."""
37-
error_code: str
38-
error_message: str
37+
error_code: str = ""
38+
error_message: str = ""
3939
details: Optional[dict] = None

0 commit comments

Comments
 (0)