remove reflective access from the executors instrumentation, fixes #641 #1136
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are finally getting rid of reflective access on JDK classes! This should remove the annoying warning (that turned into an error by default in Java 17:
A side effect of this is that we no longer can instrument certain executors returned by
java.util.concurrent.Executors)
, including the ones from:newSingleThreadExecutor
newSingleThreadScheduledExecutor
unconfigurableExecutorService
unconfigurableScheduledExecutorService
That shouldn't be a big issue, I hope.