Fix module registry name for akka disparchers #1138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivantopo
force-pushed
the
fix-module-registry-name-for-akka-disparchers
branch
from
a02edee to
96d2c20
Compare
ivantopo
force-pushed
the
fix-module-registry-name-for-akka-disparchers
branch
from
96d2c20 to
fe65cca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here I'm introducing a new parameter on the
ExecutorInstrumentationclass so we can give a specific name to the scheduled action that collects the metrics, and then prepend the actor system name to the dispatcher name when registered them. This shouldn't affect any of the metrics tags, it is only for internal Kamon usage. Fixes #1132 but should wait until #1136 is merged.