Specify platform as linux/${ARCH} when cross-building docker images
#2503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrasadG193
reviewed
Dec 1, 2023
| docker run --rm ${mount_cmd} \ | ||
| --platform linux/${ARCH}\ |
There was a problem hiding this comment.
We should also have a way to override default linux os with something like ${OS} ?
There was a problem hiding this comment.
We could, but do we anticipate that somebody ever changes base image in the dockerfile? Is there any use-case for that?
When using arch specific dockerfiles it's also necessary to specify `--platform` flag. Otherwise dockerx can build arm image with x86_64 binaries, which may not work properly in deployment.
hairyhum
force-pushed
the
build-image-arch
branch
from
dbd7d0a
to
46ec8bd
Compare
pavannd1
approved these changes
Dec 5, 2023
| @@ -66,5 +71,5 @@ sed \ | |||
| -e "s|ARG_ARCH|${ARCH}|g" \ | |||
| -e "s|ARG_SOURCE_BIN|${SOURCE_BIN}|g" \ | |||
| Dockerfile.in > .dockerfile-${ARCH} | |||
| docker buildx build --push --pull --sbom=true ${baseimagearg:-} --build-arg kanister_version=${VERSION} -t ${IMAGE}:${VERSION} -f .dockerfile-${ARCH} . | |||
| docker buildx build --push --pull --sbom=true ${baseimagearg:-} --build-arg kanister_version=${VERSION} -t ${IMAGE}:${VERSION} --platform linux/${ARCH} -f .dockerfile-${ARCH} . | |||
There was a problem hiding this comment.
Note for @PrasadG193: We should make the SBOM flag configurable. --sbom={ENABLE_SBOM} or something like that. The packaging will fail if someone doesn't have the correct buildkit enabled.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
When using arch specific dockerfiles it's also necessary to specify
--platformflag. Otherwise dockerx can build arm image with x86_64 binaries, which may not work properly in deployment.Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan
To test run on arm64 arch (M1/M2 mac):
Then check produced image:
Without changes:
With changes
To run full test follow the steps in #2091