Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(release): add reno tools to build image and makefile #2604

Merged
merged 9 commits into from
Jun 19, 2024

Conversation

hairyhum
Copy link
Contributor

Change Overview

Tooling to make use of reno release notes generation tool

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

@hairyhum hairyhum changed the title build(release): use reno for release notes build(release): add reno tools to build image and makefile Mar 15, 2024
@hairyhum hairyhum marked this pull request as ready for review March 15, 2024 17:34
This was referenced Mar 20, 2024
@hairyhum hairyhum marked this pull request as draft March 28, 2024 19:26
@hairyhum hairyhum marked this pull request as ready for review April 9, 2024 20:48
@e-sumin e-sumin self-requested a review April 11, 2024 16:38
.gitignore Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
releasenotes/README.md Show resolved Hide resolved
releasenotes/README.md Outdated Show resolved Hide resolved
releasenotes/README.md Outdated Show resolved Hide resolved
reno.yaml Show resolved Hide resolved
releasenotes/README.md Outdated Show resolved Hide resolved
CODE_REVIEW.md Outdated Show resolved Hide resolved
CODE_REVIEW.md Outdated Show resolved Hide resolved
CODE_REVIEW.md Outdated Show resolved Hide resolved
CODE_REVIEW.md Show resolved Hide resolved
CODE_REVIEW.md Outdated Show resolved Hide resolved
CODE_REVIEW.md Outdated Show resolved Hide resolved
CODE_REVIEW.md Show resolved Hide resolved
build/reno_report.sh Outdated Show resolved Hide resolved
build/reno_report.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@viveksinghggits viveksinghggits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, after addressing few minor comments.

releasenotes/README.md Outdated Show resolved Hide resolved
releasenotes/README.md Outdated Show resolved Hide resolved
Comment on lines 36 to 38
CHANGELOG_CURRENT.md only containing changes for the current version.

It will be used when running goreleaser build using make (will use `CHANGELOG_CURRENT.md` by default):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should these sentences be together?
Also CHANGELOG_CURRENT.md only containing changes for the current version. doesn't seem right.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also CHANGELOG_CURRENT.md only containing changes for the current version. doesn't seem right.

Can you elaborate?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rephrased

Copy link
Contributor

@e-sumin e-sumin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 679c2ed into master Jun 19, 2024
15 checks passed
@mergify mergify bot deleted the reno-changelog branch June 19, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants