Surround subquery in the args aggregate function #549
Conversation
|
Why? This pr is more early than #566. I also add test fully |
|
@magiskboy like I said there is a conflict in this, so I cannot merge it now. Either you fix it or #566 adds tests. I'll merge whatever happens first. |
pypika/terms.py
Outdated
| name=self.name, | ||
| args=",".join(self.get_arg_sql(arg, **kwargs) for arg in self.args), | ||
| args=",".join( | ||
| p.get_sql(with_alias=False, subquery=True, **kwargs) if hasattr(p, "get_sql") else str(p) |
There was a problem hiding this comment.
Can you please keep using self.get_arg_sql(arg, **kwargs) for the non subquery case as before? Its implementation isn't exactly equal to str(p).
There was a problem hiding this comment.
I think that this function get_function_sql is called if once this is a sub-query, but not all of the terms
There was a problem hiding this comment.
because function is only used in subquery
There was a problem hiding this comment.
Not sure I understood you. I mean changing:
args=",".join( p.get_sql(with_alias=False, subquery=True, **kwargs) if hasattr(p, "get_sql") else str(p)
to:
args=",".join( p.get_sql(with_alias=False, subquery=True, **kwargs) if hasattr(p, "get_sql") else self.get_arg_sql(arg, **kwargs)
There was a problem hiding this comment.
what is arg? I can't see it
There was a problem hiding this comment.
You've changed arg to p, as you can see in diff. So that's essentially the element from the self.args, which we are iterating.
There was a problem hiding this comment.
Arg is a better variable name in this case btw.
No description provided.