Skip to content

Surround subquery in the args aggregate function #549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 24, 2021
Merged

Surround subquery in the args aggregate function #549

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a7eaa75
Surround subquery in the args aggregate function
magiskboy Feb 4, 2021
a9b7f80
reformat code
magiskboy Feb 4, 2021
876afce
Merge branch 'master' into subquery-in-function
magiskboy Mar 16, 2021
42ffe3a
get sql string as arg sql
magiskboy Mar 24, 2021
7fb5127
refactor linting
magiskboy Mar 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion pypika/terms.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1259,7 +1259,12 @@ def get_function_sql(self, **kwargs: Any) -> str:

return "{name}({args}{special})".format(
name=self.name,
args=",".join(self.get_arg_sql(arg, **kwargs) for arg in self.args),
args=",".join(
p.get_sql(with_alias=False, subquery=True, **kwargs)
if hasattr(p, "get_sql")
else self.get_arg_sql(p, **kwargs)
for p in self.args
),
special=(" " + special_params_sql) if special_params_sql else "",
)

Expand Down
5 changes: 5 additions & 0 deletions pypika/tests/test_functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,6 +413,11 @@ def test__approx_percentile(self):
str(q),
)

def test__subquery_in_params_functions(self):
subquery = Query.from_('table').select('id')
func = fn.Function('func', 'id', subquery)
self.assertEqual("func('id',(SELECT id FROM table))", func.get_sql())


class ConditionTests(unittest.TestCase):
def test__case__raw(self):
Expand Down