Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DATAUP-280 GitHub action for testing #1900

Closed
wants to merge 72 commits into from
Closed

DATAUP-280 GitHub action for testing #1900

wants to merge 72 commits into from

Conversation

briehl
Copy link
Member

@briehl briehl commented Oct 27, 2020

DO NOT MERGE
Making this a draft PR for now (though I'm not sure how it'll affect the actions).

Description of PR purpose/changes

  • Please include a summary of the change and which issue is fixed.
  • Please also include relevant motivation and context.
  • List any dependencies that are required for this change.

Jira Ticket / Issue

e.g. https://kbase-jira.atlassian.net/browse/DATAUP-X

  • Added the Jira Ticket to the title of the PR e.g. (DATAUP-69 Adds a PR template)

Testing Instructions

  • Details for how to test the PR:
  • Tests pass in travis and locally
  • Changes available by spinning up a local narrative and navigating to X to see Y

Dev Checklist:

  • My code follows the guidelines at https://sites.google.com/truss.works/kbasetruss/development
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have run Black and Flake8 on changed Python Code manually or with git precommit (and the travis build passes)

Updating Version and Release Notes (if applicable)

briehl and others added 24 commits October 21, 2020 16:23
Bumps [puppeteer](https://github.com/puppeteer/puppeteer) from 5.3.1 to 5.4.0.
- [Release notes](https://github.com/puppeteer/puppeteer/releases)
- [Commits](puppeteer/puppeteer@v5.3.1...v5.4.0)

Signed-off-by: dependabot[bot] <support@github.com>
…-5.4.0

Bump puppeteer from 5.3.1 to 5.4.0
@sonarcloud
Copy link

sonarcloud bot commented Oct 27, 2020

SonarCloud Quality Gate failed.

Bug D 16 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 6 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

@codecov
Copy link

codecov bot commented Oct 27, 2020

Codecov Report

❗ No coverage uploaded for pull request base (develop@30836bc). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1900   +/-   ##
==========================================
  Coverage           ?   17.90%           
==========================================
  Files              ?      446           
  Lines              ?    48128           
  Branches           ?        0           
==========================================
  Hits               ?     8619           
  Misses             ?    39509           
  Partials           ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30836bc...47a4d5d. Read the comment docs.

@briehl briehl changed the base branch from develop to truss October 27, 2020 16:58
@lgtm-com
Copy link

lgtm-com bot commented Oct 27, 2020

This pull request fixes 1 alert when merging 47a4d5d into a30f5aa - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@briehl briehl closed this Oct 27, 2020
@ialarmedalien ialarmedalien deleted the github-action branch June 15, 2021 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants