Skip to content

Fix JsonHelper implementation and tests #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 2, 2019
Merged

Fix JsonHelper implementation and tests #54

merged 1 commit into from
Jan 2, 2019

Conversation

tomasfejfar
Copy link
Contributor

  • without @ it won't proceed to exception, but will throw normal internal warning that is converted to error.
  • Exception was missing sprintf
  • test tests correct exception message
  • writing to root worked for me just fine - so the test failed (that's different in travis as it does not run as root)

Fixes: #52 (comment)

@tomasfejfar tomasfejfar self-assigned this Dec 28, 2018
@tomasfejfar tomasfejfar requested a review from Actimel December 28, 2018 15:56
@tomasfejfar tomasfejfar mentioned this pull request Dec 28, 2018
Merged
odinuv
odinuv reviewed Dec 28, 2018
View reviewed changes
@tomasfejfar tomasfejfar requested a review from odinuv January 2, 2019 18:08
odinuv
odinuv reviewed Jan 2, 2019
View reviewed changes
Copy link
Member

@odinuv odinuv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

budiz :)

@tomasfejfar tomasfejfar merged commit ac9f79d into master Jan 2, 2019
@tomasfejfar tomasfejfar deleted the tf-fix-json-helper branch January 2, 2019 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@odinuv odinuv odinuv approved these changes

@Actimel Actimel Awaiting requested review from Actimel

Assignees

@tomasfejfar tomasfejfar

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tomasfejfar @odinuv