Skip to content

Make php-component 7.3 ready #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 29, 2018
Merged

Make php-component 7.3 ready #53

merged 5 commits into from
Dec 29, 2018

Conversation

tomasfejfar
Copy link
Contributor

@tomasfejfar tomasfejfar commented Dec 25, 2018 •
edited
Loading

Depends on #54

Fixes:

  • Keboola CS < 7 is not compatible with php7.3 → new CS required a fix
  • latest phpunit deprecated syntaxCheck parameter
  • symfony/config fixes 7.3 compatiblity in v4.1.4, changed required version to latest 4.2
  • travis tests didn't test 7.3 (only nightly that is allowed to fail)
  • local docker does not use "open" php version → changed to php:7-cli

@tomasfejfar tomasfejfar self-assigned this Dec 25, 2018
@tomasfejfar tomasfejfar mentioned this pull request Dec 25, 2018
Merged
@tomasfejfar tomasfejfar force-pushed the tf-php73 branch 2 times, most recently from 59f65a7 to e45ba75 Compare December 28, 2018 15:59
@tomasfejfar tomasfejfar merged commit 49accf7 into master Dec 29, 2018
@tomasfejfar tomasfejfar deleted the tf-php73 branch December 29, 2018 11:52
@tomasfejfar
Copy link
Contributor Author

Vykopnul jsem z toho zatím ten JSON, ať se tohle může mergnout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@odinuv odinuv odinuv approved these changes

@Actimel Actimel Awaiting requested review from Actimel

Assignees

@tomasfejfar tomasfejfar

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tomasfejfar @odinuv