New native datatypes fix ups #83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ondrajodas
previously approved these changes
Jun 18, 2024
ondrajodas
reviewed
Jun 18, 2024
|
Ještě tu bude potřeba vyřešit asi tohle: https://keboolaglobal.slack.com/archives/C06LY0QJ3C5/p1718710755714529?thread_ts=1718699241.839479&cid=C06LY0QJ3C5 |
Take nakonec necháme být. Tak můžeš CR @ondrajodas pls |
ondrajodas
reviewed
Jun 18, 2024
src/Config/DatatypeSupport.php
Outdated
| enum DatatypeSupport: string | ||
| { | ||
| case AUTHORITATIVE = 'authoritative'; | ||
| case HINT = 'hint'; |
AdamVyborny
force-pushed
the
adamvyborny-PST-1376
branch
2 times, most recently
from
d670414 to
e0e9c58
Compare
AdamVyborny
force-pushed
the
adamvyborny-PST-1376
branch
from
e0e9c58 to
4d20441
Compare
ondrajodas
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Přidávám ještě check na ten data type support do configu a ty chybějící properties do manifestu