Skip to content

Commit 0f1540a

Browse files
committed
Prepare release 1.6.0
1 parent fe32207 commit 0f1540a

File tree

4 files changed

+15
-13
lines changed

4 files changed

+15
-13
lines changed

ChangeLog.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
Version:1.6.0
2+
* Add BaseManagerImpl. Logic and data shared by multiple controllers can be put into managers and injected into controllers.
3+
* Delegate fragment's onViewReady lifecycle will be called after state of all controllers are restored if activity is killed by OS
4+
15
Version:1.5.3
26
* MvcGraph able to inject concrete class with a public constructor
37
* Fix bug that sub fragments' controller do not restore state
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
* Managers should only be serving controllers and not visible to views.
1616
* </p>
1717
*/
18-
public abstract class AbstractStatefulManager<STATE> implements StateManaged<STATE>,
18+
public abstract class BaseManagerImpl<STATE> implements StateManaged<STATE>,
1919
Constructable, Disposable {
2020
private STATE state;
2121

library/android-mvc-controller/src/test/java/com/shipdream/lib/android/mvc/manager/TestStatefulManager.java

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
public class TestStatefulManager {
77
@Test(expected = IllegalArgumentException.class)
88
public void should_throw_exception_when_bind_null_to_stateful_manager() {
9-
AbstractStatefulManager manager = new AbstractStatefulManager() {
9+
BaseManagerImpl manager = new BaseManagerImpl() {
1010
@Override
1111
public Class getStateType() {
1212
return String.class;
@@ -18,7 +18,7 @@ public Class getStateType() {
1818

1919
@Test
2020
public void should_rebind_state_after_restoring_manager() {
21-
AbstractStatefulManager<String> manager = new AbstractStatefulManager() {
21+
BaseManagerImpl<String> manager = new BaseManagerImpl() {
2222

2323
@Override
2424
public Class getStateType() {
@@ -35,7 +35,7 @@ public Class getStateType() {
3535

3636
@Test
3737
public void should_call_on_restore_call_back_after_manager_is_restored() {
38-
class MyManager extends AbstractStatefulManager<String> {
38+
class MyManager extends BaseManagerImpl<String> {
3939
private boolean called = false;
4040

4141
@Override
@@ -60,7 +60,7 @@ public void onRestored() {
6060
}
6161

6262
public void should_create_state_instance_on_construct_when_the_state_type_is_specified_for_a_stateful_manager() {
63-
class MyManager extends AbstractStatefulManager<String> {
63+
class MyManager extends BaseManagerImpl<String> {
6464
@Override
6565
public Class getStateType() {
6666
return String.class;
@@ -76,7 +76,7 @@ public Class getStateType() {
7676
}
7777

7878
public void should_NOT_create_state_instance_on_construct_when_the_state_type_is_null_for_a_stateful_manager() {
79-
class MyManager extends AbstractStatefulManager {
79+
class MyManager extends BaseManagerImpl {
8080
@Override
8181
public Class getStateType() {
8282
return null;
@@ -97,7 +97,7 @@ class BadClass {
9797
{int x = 1 / 0;}
9898
}
9999

100-
class MyManager extends AbstractStatefulManager<BadClass> {
100+
class MyManager extends BaseManagerImpl<BadClass> {
101101
@Override
102102
public Class<BadClass> getStateType() {
103103
return BadClass.class;
@@ -111,7 +111,7 @@ public Class<BadClass> getStateType() {
111111

112112
@Test(expected = IllegalArgumentException.class)
113113
public void should_throw_excpetion_when_binding_null_to_stateful_manager() {
114-
class MyManager extends AbstractStatefulManager<String> {
114+
class MyManager extends BaseManagerImpl<String> {
115115
@Override
116116
public Class<String> getStateType() {
117117
return String.class;
@@ -125,7 +125,7 @@ public Class<String> getStateType() {
125125

126126
@Test
127127
public void should_be_able_to_successfully_bind_state_to_stateful_manager() {
128-
class MyManager extends AbstractStatefulManager<String> {
128+
class MyManager extends BaseManagerImpl<String> {
129129
@Override
130130
public Class<String> getStateType() {
131131
return String.class;

library/android-mvc-test/src/main/java/com/shipdream/lib/android/mvc/view/injection/manager/internal/AccountManagerImpl.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,12 @@
11
package com.shipdream.lib.android.mvc.view.injection.manager.internal;
22

3-
import com.shipdream.lib.android.mvc.Constructable;
4-
import com.shipdream.lib.android.mvc.StateManaged;
5-
import com.shipdream.lib.android.mvc.manager.AbstractStatefulManager;
3+
import com.shipdream.lib.android.mvc.manager.BaseManagerImpl;
64
import com.shipdream.lib.android.mvc.view.injection.manager.AccountManager;
75
import com.shipdream.lib.android.mvc.view.injection.service.StorageService;
86

97
import javax.inject.Inject;
108

11-
public class AccountManagerImpl extends AbstractStatefulManager<AccountManager.Session>
9+
public class AccountManagerImpl extends BaseManagerImpl<AccountManager.Session>
1210
implements AccountManager {
1311

1412
@Inject

0 commit comments

Comments
 (0)