New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:+1: add build, push and deploy commands #2

Closed
wants to merge 3 commits into
base: ja
from

Conversation

Projects
None yet
2 participants
@toshi0607

toshi0607 commented Sep 28, 2018

I joined the hands-on at Serverless Conf Tokyo 2018. It's annoying typing these commands a little.
So I'd like to add build, push and deploy commands!

kenfdev and others added some commits Mar 8, 2018

Initial Japanese version of the OpenFaaS workshop
The following version(commit) is translated to Japanese.
df8d19b

Signed-off-by: Ken Fukuyama <kenfdev@gmail.com>
@kenfdev

This comment has been minimized.

Owner

kenfdev commented Oct 12, 2018

Hi @toshi0607 ! Thanks for your contribution and thanks for attending the workshop, too. Sorry about my late response. I haven't had enough time.

You're suggestion makes sense, but we need to change the original (English) version before this Japanese version.

In addition, the build push deploy command has been replaced recently in this commit. Do you have time to catch up and create a PR for this? Thanks!

Also, don't forget to sign-off your commits with git commit -s.

@kenfdev

This comment has been minimized.

Owner

kenfdev commented Oct 13, 2018

Awesome @toshi0607 ! Thanks a lot for this update. There are few things to finish this PR.

  • Please rebase this so that I can merge it :)
  • Please sign your commit with git commit -s or git commit -s --amend
  • Please follow the commit message guide here

e.g.

Add alexellis to the .DEREK.yml file

We need to add alexellis to the .DEREK.yml file for project maintainer
duties.

Signed-off-by: Alex Ellis <alex@openfaas.com>
@toshi0607

This comment has been minimized.

toshi0607 commented Oct 13, 2018

retried in this PR
openfaas#78

@toshi0607 toshi0607 closed this Oct 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment