Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: precommit hook on windows #156

Merged
merged 1 commit into from
Jun 30, 2020

Conversation

timdeschryver
Copy link
Contributor

@timdeschryver timdeschryver commented Jun 30, 2020

What:

  • Make the pre commit hook work on windows
  • The problem was that the path had backslashes in it and the pre-commit hook thought this was a regex. A path "C:\dev\repo\foo\husky.cmd" was translated to "C:devrepofoohusky.cmd", making that the cmd couldn't be found.

Why:

  • I encountered problems with it in Dom Testing Library

How:

  • Wrap the path between quotes

Checklist:

  • Documentation
  • Tests
  • Ready to be merged

@codecov
Copy link

codecov bot commented Jun 30, 2020

Codecov Report

Merging #156 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #156   +/-   ##
=======================================
  Coverage   86.82%   86.82%           
=======================================
  Files          18       18           
  Lines         334      334           
  Branches       79       79           
=======================================
  Hits          290      290           
  Misses         36       36           
  Partials        8        8           
Impacted Files Coverage Δ
src/config/huskyrc.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6784da2...96acf72. Read the comment docs.

Copy link
Owner

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

@kentcdodds kentcdodds merged commit 2349278 into kentcdodds:master Jun 30, 2020
@kentcdodds
Copy link
Owner

@all-contributors please add @timdeschryver for code

@kentcdodds
Copy link
Owner

Thanks @timdeschryver!

@allcontributors
Copy link
Contributor

@kentcdodds

I've put up a pull request to add @timdeschryver! 🎉

@kentcdodds
Copy link
Owner

🎉 This PR is included in version 6.2.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants