-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Add 7 Matrix Unit Tests and Implement Matrix Multiplication #497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull Request Test Coverage Report for Build 894
💛 - Coveralls |
tests/test_matrix.py
Outdated
7, 1, 3, 9, 2, 4, 8, 5, 6], [ | ||
9, 6, 1, 5, 3, 7, 2, 8, 4], [ | ||
2, 8, 7, 4, 1, 9, 6, 3, 5], [ | ||
3, 4, 5, 2, 8, 6, 1, 7, 9]])) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's align the columns in the same level
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. It's auto-formatted by the autopep8 LOL
algorithms/matrix/multiply.py
Outdated
return result | ||
|
||
|
||
# def main(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
forgot to remove these?
thanks for the contribution! this will be a nice addition to the matrix related algo. |
Just updated! Thanks for the review. |
(Put an
X
inside the[ ]
to denote check mark[X]
.)If creating a new file:
if done some changes:
other