-
Notifications
You must be signed in to change notification settings - Fork 244
CLI prints deprecation warning about extensions/v1beta1 when doing keptn auth #4432
Comments
Hello, I would like to work in it, I have been playing around with Keptn for some days and would like to take this up to have my first entry point in the project |
Hi @ritwizsinha! Thank you for helping us 😄 |
So, what I understand from looking at some documentation and looking at this kubernetes-client package is that I have to use the Networking V1 type of client which allows us to interact with features given by networking.k8s.io group to avoid a warning The task list above says that
The question I have is, do I have to replace the v1Beta1 client with the networkingv1 client or do I have to use the networkingv1 client whenever the v1beta1 client shows a warning. |
@thisthat can I pick this up? |
Hey @nvzard sure! Thank you a lot for helping us out 😊 |
Closes keptn/keptn#4432 Signed-off-by: Nitanshu Vashistha <nitanshu.vzard@gmail.com>
Fixes keptn/keptn#4432 Signed-off-by: Nitanshu Vashistha <nitanshu.vzard@gmail.com>
Can someone please review this? keptn/kubernetes-utils#163 I guess I'll also need to upgrade the version of kubernetes-utils package being used by keptn cli. |
Fixes keptn/keptn#4432 Signed-off-by: Nitanshu Vashistha <nitanshu.vzard@gmail.com>
Made the PR for the correct repo. Can someone please review it? |
Fixes keptn/keptn#4432 Signed-off-by: Nitanshu Vashistha <nitanshu.vzard@gmail.com>
Fixes keptn/keptn#4432 Signed-off-by: Nitanshu Vashistha <nitanshu.vzard@gmail.com>
With Keptn 0.8.4, when executing
keptn auth
without parameters, the following deprecation warning is shown:This is caused by the function
GetKeptnEndpointFromIngress
which is implemented in kubernetes-utils:https://github.com/keptn/kubernetes-utils/blob/334fb680480c179fdee3503dc6297ce067457945/pkg/kubernetes-utils.go#L345-L357
Definition of Done
keptn auth
without parametersGetKeptnEndpointFromIngress
has been adapted to also work withnetworking.k8s.io/v1
The text was updated successfully, but these errors were encountered: