Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

CLI prints deprecation warning about extensions/v1beta1 when doing keptn auth #4432

Closed
3 tasks
christian-kreuzberger-dtx opened this issue Jun 22, 2021 · 7 comments · Fixed by keptn/go-utils#492
Assignees
Labels
area:cli area:core good first issue Issues for getting started developing Keptn type:improvement Improves/enhances an existing feature
Milestone

Comments

@christian-kreuzberger-dtx
Copy link
Member

christian-kreuzberger-dtx commented Jun 22, 2021

With Keptn 0.8.4, when executing keptn auth without parameters, the following deprecation warning is shown:

$ keptn auth
W0622 09:12:38.907621  114793 warnings.go:70] extensions/v1beta1 Ingress is deprecated in v1.14+, unavailable in v1.22+; use networking.k8s.io/v1 Ingress

This is caused by the function GetKeptnEndpointFromIngress which is implemented in kubernetes-utils:
https://github.com/keptn/kubernetes-utils/blob/334fb680480c179fdee3503dc6297ce067457945/pkg/kubernetes-utils.go#L345-L357

Definition of Done

  • The warning is no longer shown when executing keptn auth without parameters
  • kubernetes-utils function GetKeptnEndpointFromIngress has been adapted to also work with networking.k8s.io/v1
  • Get rid of all beta APIs
@christian-kreuzberger-dtx christian-kreuzberger-dtx added area:cli good first issue Issues for getting started developing Keptn type:improvement Improves/enhances an existing feature labels Jun 22, 2021
@ritwizsinha
Copy link

Hello, I would like to work in it, I have been playing around with Keptn for some days and would like to take this up to have my first entry point in the project

@thisthat
Copy link
Member

Hi @ritwizsinha! Thank you for helping us 😄
I will assign the issue to you then!

@ritwizsinha
Copy link

So, what I understand from looking at some documentation and looking at this kubernetes-client package is that I have to use the Networking V1 type of client which allows us to interact with features given by networking.k8s.io group to avoid a warning

The task list above says that

kubernetes-utils function GetKeptnEndpointFromIngress has been adapted to also work with networking.k8s.io/v1

The question I have is, do I have to replace the v1Beta1 client with the networkingv1 client or do I have to use the networkingv1 client whenever the v1beta1 client shows a warning.

@thisthat thisthat added ready-for-refinement Issue is relevant for the next backlog refinment area:core labels Oct 27, 2021
@thisthat thisthat removed the ready-for-refinement Issue is relevant for the next backlog refinment label Nov 2, 2021
@johannes-b johannes-b removed this from the Help wanted / Good first issues milestone Mar 31, 2022
@johannes-b johannes-b added this to the 0.16.0 milestone Mar 31, 2022
@thisthat thisthat removed this from the 0.16.0 milestone May 25, 2022
@nvzard
Copy link

nvzard commented Jun 19, 2022

@thisthat can I pick this up?

@thisthat
Copy link
Member

Hey @nvzard sure! Thank you a lot for helping us out 😊

nvzard added a commit to nvzard/kubernetes-utils that referenced this issue Jun 26, 2022
Closes keptn/keptn#4432
Signed-off-by: Nitanshu Vashistha <nitanshu.vzard@gmail.com>
nvzard added a commit to nvzard/kubernetes-utils that referenced this issue Jun 26, 2022
Fixes keptn/keptn#4432

Signed-off-by: Nitanshu Vashistha <nitanshu.vzard@gmail.com>
@nvzard
Copy link

nvzard commented Jun 26, 2022

Can someone please review this? keptn/kubernetes-utils#163

I guess I'll also need to upgrade the version of kubernetes-utils package being used by keptn cli.
Shall I do that after this PR is merged and a kubernetes-util release is made?

nvzard added a commit to nvzard/go-utils that referenced this issue Jul 1, 2022
Fixes keptn/keptn#4432

Signed-off-by: Nitanshu Vashistha <nitanshu.vzard@gmail.com>
@nvzard
Copy link

nvzard commented Jul 1, 2022

keptn/go-utils#492

Made the PR for the correct repo. Can someone please review it?

nvzard added a commit to nvzard/go-utils that referenced this issue Jul 5, 2022
Fixes keptn/keptn#4432

Signed-off-by: Nitanshu Vashistha <nitanshu.vzard@gmail.com>
warber pushed a commit to keptn/go-utils that referenced this issue Jul 5, 2022
Fixes keptn/keptn#4432

Signed-off-by: Nitanshu Vashistha <nitanshu.vzard@gmail.com>
@thisthat thisthat added this to the 0.17.0 milestone Jul 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area:cli area:core good first issue Issues for getting started developing Keptn type:improvement Improves/enhances an existing feature
Projects
None yet
5 participants