Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

fix(shipyard-controller): Reduce log noise of sequence migrator (#5096) #5121

Closed
wants to merge 12 commits into from
Closed

fix(shipyard-controller): Reduce log noise of sequence migrator (#5096) #5121

wants to merge 12 commits into from

Conversation

bacherfl
Copy link
Member

@bacherfl bacherfl commented Sep 1, 2021

Closes #5096

agrimmer and others added 10 commits August 31, 2021 09:52
@agrimmer
fix: Correct log level for storing root events (#5075)
78e55bb
@dependabot
build(deps): bump k8s.io/apimachinery in /test/go-tests (#5112)
58cca97 
Bumps [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) from 0.21.3 to 0.22.1.
- [Release notes](https://github.com/kubernetes/apimachinery/releases)
- [Commits](kubernetes/apimachinery@v0.21.3...v0.22.1)

---
updated-dependencies:
- dependency-name: k8s.io/apimachinery
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
build(deps): bump github.com/nats-io/nats-server/v2 (#5107)
fb4b77f 
Bumps [github.com/nats-io/nats-server/v2](https://github.com/nats-io/nats-server) from 2.3.4 to 2.4.0.
- [Release notes](https://github.com/nats-io/nats-server/releases)
- [Changelog](https://github.com/nats-io/nats-server/blob/main/.goreleaser.yml)
- [Commits](nats-io/nats-server@v2.3.4...v2.4.0)

---
updated-dependencies:
- dependency-name: github.com/nats-io/nats-server/v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
build(deps): bump github.com/go-openapi/runtime in /mongodb-datastore (…
9e4ac35 
…#5105)

Bumps [github.com/go-openapi/runtime](https://github.com/go-openapi/runtime) from 0.19.30 to 0.19.31.
- [Release notes](https://github.com/go-openapi/runtime/releases)
- [Commits](go-openapi/runtime@v0.19.30...v0.19.31)

---
updated-dependencies:
- dependency-name: github.com/go-openapi/runtime
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
build(deps): bump github.com/nats-io/nats-server/v2 in /distributor (#…
57bfae0 
…5104)

Bumps [github.com/nats-io/nats-server/v2](https://github.com/nats-io/nats-server) from 2.3.4 to 2.4.0.
- [Release notes](https://github.com/nats-io/nats-server/releases)
- [Changelog](https://github.com/nats-io/nats-server/blob/main/.goreleaser.yml)
- [Commits](nats-io/nats-server@v2.3.4...v2.4.0)

---
updated-dependencies:
- dependency-name: github.com/nats-io/nats-server/v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
build(deps): bump marocchino/sticky-pull-request-comment (#5103)
49b7f7e 
Bumps [marocchino/sticky-pull-request-comment](https://github.com/marocchino/sticky-pull-request-comment) from 2.1.0 to 2.1.1.
- [Release notes](https://github.com/marocchino/sticky-pull-request-comment/releases)
- [Commits](marocchino/sticky-pull-request-comment@v2.1.0...v2.1.1)

---
updated-dependencies:
- dependency-name: marocchino/sticky-pull-request-comment
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@bacherfl @thisthat
fix(api): Try to use X-real-ip and X-forwarded-for headers before Rem… (
c47f466 
#5080)

* fix(api): Try to use X-real-ip and X-forwarded-for headers before RemoteAddress

Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>

* fix(api): Try to use X-real-ip and X-forwarded-for headers before RemoteAddress

Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>

Co-authored-by: Giovanni Liva <giovanni.liva@dynatrace.com>
@dependabot
build(deps): bump github.com/go-openapi/errors in /configuration-serv…
0d21210 
…ice (#5036)

Bumps [github.com/go-openapi/errors](https://github.com/go-openapi/errors) from 0.19.9 to 0.20.1.
- [Release notes](https://github.com/go-openapi/errors/releases)
- [Commits](go-openapi/errors@v0.19.9...v0.20.1)

---
updated-dependencies:
- dependency-name: github.com/go-openapi/errors
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
build(deps): bump k8s.io/client-go from 0.21.3 to 0.22.1 in /api (#5027)
de03c96 
Bumps [k8s.io/client-go](https://github.com/kubernetes/client-go) from 0.21.3 to 0.22.1.
- [Release notes](https://github.com/kubernetes/client-go/releases)
- [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md)
- [Commits](kubernetes/client-go@v0.21.3...v0.22.1)

---
updated-dependencies:
- dependency-name: k8s.io/client-go
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@bacherfl
fix(shipyard-controller): Remove log noise (#5096)
bc956ef 
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@bacherfl bacherfl requested a review from a team as a code owner September 1, 2021 07:49
@codecov
Copy link

codecov bot commented Sep 1, 2021 •
edited

Codecov Report

Merging #5121 (dc1be44) into release-0.9.0 (4890846) will decrease coverage by 0.49%.
The diff coverage is 61.90%.

❗ Current head dc1be44 differs from pull request most recent head 5b4baad. Consider uploading reports for the commit 5b4baad to get more accurate results

@@                Coverage Diff                @@
##           release-0.9.0    #5121      +/-   ##
=================================================
- Coverage          52.26%   51.76%   -0.50%     
=================================================
  Files                299      293       -6     
  Lines              17581    17312     -269     
  Branches             692      692              
=================================================
- Hits                9189     8962     -227     
+ Misses              7531     7496      -35     
+ Partials             861      854       -7
Impacted Files Coverage Δ
mongodb-datastore/handlers/events.go 25.46% <0.00%> (ø)
...project-settings/ktb-project-settings.component.ts 70.24% <66.66%> (+0.24%) ⬆️
shipyard-controller/handler/sequence_migrator.go 72.72% <70.00%> (+0.16%) ⬆️
distributor/pkg/lib/controlplane/uniformlog.go 74.07% <0.00%> (-5.56%) ⬇️
secret-service/pkg/handler/secrethandler.go
secret-service/pkg/common/utils.go
secret-service/pkg/repository/scopes.go
secret-service/pkg/backend/registry.go
secret-service/pkg/backend/secretbackend_k8s.go
secret-service/pkg/handler/common.go

laneli
laneli previously approved these changes Sep 1, 2021
View reviewed changes
@bacherfl
avoid endless loop
49b12dd 
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
laneli
laneli previously approved these changes Sep 1, 2021
View reviewed changes
@bacherfl
Merge branch 'master' into bug/5096/migrate-sequences-backport-090
5b4baad 
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@bacherfl bacherfl force-pushed the bug/5096/migrate-sequences-backport-090 branch from 0bdcbbb to 5b4baad Compare September 1, 2021 09:21
@sonarcloud
Copy link

sonarcloud bot commented Sep 1, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2021 •
edited

Docker Build Report

  • Pushed keptn/shipyard-controller:0.8.8-dev-PR-5121.202109010916 and keptn/shipyard-controller:0.8.8-dev-PR-5121 (Source: shipyard-controller/)
  • Pushed keptn/api:0.8.8-dev-PR-5121.202109010922 and keptn/api:0.8.8-dev-PR-5121 (Source: api/)
  • Pushed keptn/distributor:0.8.8-dev-PR-5121.202109010922 and keptn/distributor:0.8.8-dev-PR-5121 (Source: distributor/)
  • Pushed keptn/shipyard-controller:0.8.8-dev-PR-5121.202109010918 and keptn/shipyard-controller:0.8.8-dev-PR-5121 (Source: shipyard-controller/)
  • Pushed keptn/mongodb-datastore:0.8.8-dev-PR-5121.202109010922 and keptn/mongodb-datastore:0.8.8-dev-PR-5121 (Source: mongodb-datastore/)
  • Pushed keptn/lighthouse-service:0.8.8-dev-PR-5121.202109010922 and keptn/lighthouse-service:0.8.8-dev-PR-5121 (Source: lighthouse-service/)
  • Pushed keptn/configuration-service:0.8.8-dev-PR-5121.202109010922 and keptn/configuration-service:0.8.8-dev-PR-5121 (Source: configuration-service/)
  • Pushed keptn/shipyard-controller:0.8.8-dev-PR-5121.202109010922 and keptn/shipyard-controller:0.8.8-dev-PR-5121 (Source: shipyard-controller/)

@bacherfl bacherfl closed this Sep 1, 2021
@mowies mowies deleted the bug/5096/migrate-sequences-backport-090 branch October 6, 2021 11:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@laneli laneli laneli left review comments

@christian-kreuzberger-dtx christian-kreuzberger-dtx Awaiting requested review from christian-kreuzberger-dtx christian-kreuzberger-dtx is a code owner

@mowies mowies Awaiting requested review from mowies mowies is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bacherfl @laneli @agrimmer