Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(operator): refactor keptntaskcontroller to use builder interface #1450

Merged
merged 6 commits into from
May 26, 2023
Merged

chore(operator): refactor keptntaskcontroller to use builder interface #1450

merged 6 commits into from
May 26, 2023

Conversation

RealAnna
Copy link
Contributor

@RealAnna RealAnna commented May 23, 2023 •
edited
Loading

closes #1420

@netlify
Copy link

netlify bot commented May 23, 2023 •
edited
Loading

✅ Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit ef6f2b0
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/646f73dd69da590008663b4d
😎 Deploy Preview https://deploy-preview-1450--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented May 23, 2023 •
edited
Loading

Codecov Report

Merging #1450 (26cc912) into main (ecd8c48) will increase coverage by 0.35%.
The diff coverage is 71.79%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1450      +/-   ##
==========================================
+ Coverage   61.92%   62.28%   +0.35%     
==========================================
  Files         137      139       +2     
  Lines       10487    10634     +147     
==========================================
+ Hits         6494     6623     +129     
- Misses       3743     3750       +7     
- Partials      250      261      +11
Impacted Files Coverage Δ
...ator/controllers/lifecycle/keptntask/js_builder.go 69.92% <54.09%> (ø)
...ntrollers/lifecycle/keptntask/container_builder.go 90.90% <90.90%> (ø)
...rator/controllers/lifecycle/keptntask/job_utils.go 68.54% <91.11%> (+25.30%) ⬆️

... and 3 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 68.55% <ø> (ø)
component-tests 58.92% <62.39%> (-0.13%) ⬇️
lifecycle-operator 83.94% <71.79%> (+0.23%) ⬆️
metrics-operator 80.51% <ø> (ø)
scheduler 21.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@RealAnna RealAnna force-pushed the chore/1420/refactor_task_controller branch 2 times, most recently from c920c42 to 72e4ef8 Compare May 23, 2023 13:28
@RealAnna RealAnna force-pushed the chore/1420/refactor_task_controller branch from 80fbe58 to 199d9c8 Compare May 23, 2023 14:02
@RealAnna RealAnna marked this pull request as ready for review May 23, 2023 14:38
@RealAnna RealAnna requested review from a team as code owners May 23, 2023 14:38
@RealAnna RealAnna changed the title chore: refactor using builder interface chore: refactor keptntaskcontroller to use builder interface May 23, 2023
@RealAnna RealAnna added this to the 0.8 milestone May 23, 2023
@github-actions github-actions bot removed the documentation Improvements or additions to documentation label May 24, 2023
@odubajDT odubajDT removed this from the 0.8 milestone May 24, 2023
@RealAnna RealAnna changed the title chore: refactor keptntaskcontroller to use builder interface chore(operator): refactor keptntaskcontroller to use builder interface May 25, 2023
@RealAnna
chore: refactor container creation using builder interface
aa742dc 
Signed-off-by: realanna <anna.reale@dynatrace.com>

added builder tests

Signed-off-by: realanna <anna.reale@dynatrace.com>

added builder tests

Signed-off-by: realanna <anna.reale@dynatrace.com>

added back events

Signed-off-by: realanna <anna.reale@dynatrace.com>

chore: refactor using builder interface
Signed-off-by: realanna <anna.reale@dynatrace.com>

added i

Signed-off-by: realanna <anna.reale@dynatrace.com>

chore: refactor using builder interface

Signed-off-by: realanna <anna.reale@dynatrace.com>
@RealAnna
test params
703c6f8 
Signed-off-by: realanna <anna.reale@dynatrace.com>

lint

Signed-off-by: realanna <anna.reale@dynatrace.com>

lint

Signed-off-by: realanna <anna.reale@dynatrace.com>

lint

Signed-off-by: realanna <anna.reale@dynatrace.com>

fix based on review

Signed-off-by: realanna <anna.reale@dynatrace.com>

fix based on review

Signed-off-by: realanna <anna.reale@dynatrace.com>

fix based on review

Signed-off-by: realanna <anna.reale@dynatrace.com>

tidy

Signed-off-by: realanna <anna.reale@dynatrace.com>

tidy

Signed-off-by: realanna <anna.reale@dynatrace.com>

tidy

Signed-off-by: realanna <anna.reale@dynatrace.com>

tidy

Signed-off-by: realanna <anna.reale@dynatrace.com>

tidy

Signed-off-by: realanna <anna.reale@dynatrace.com>
@RealAnna
added tests to js-builder
ef6f2b0 
Signed-off-by: realanna <anna.reale@dynatrace.com>

added tests to js-builder

Signed-off-by: realanna <anna.reale@dynatrace.com>

added tests to js-builder

Signed-off-by: realanna <anna.reale@dynatrace.com>

added tests to js-builder

Signed-off-by: realanna <anna.reale@dynatrace.com>

added tests to js-builder

Signed-off-by: realanna <anna.reale@dynatrace.com>

added tests to js-builder

Signed-off-by: realanna <anna.reale@dynatrace.com>

added tests to js-builder

Signed-off-by: realanna <anna.reale@dynatrace.com>
@RealAnna RealAnna force-pushed the chore/1420/refactor_task_controller branch from b04b480 to ef6f2b0 Compare May 25, 2023 14:42
@RealAnna
added tests to js-builder
890b400 
Signed-off-by: realanna <anna.reale@dynatrace.com>
@RealAnna
review
d451295 
Signed-off-by: realanna <anna.reale@dynatrace.com>
bacherfl
bacherfl previously approved these changes May 26, 2023
View reviewed changes
@RealAnna
review
26cc912 
Signed-off-by: realanna <anna.reale@dynatrace.com>
@sonarcloud
Copy link

sonarcloud bot commented May 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

odubajDT
odubajDT approved these changes May 26, 2023
View reviewed changes
Copy link
Contributor

@odubajDT odubajDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work! :)

@RealAnna RealAnna merged commit a3f5e5b into main May 26, 2023
@RealAnna RealAnna deleted the chore/1420/refactor_task_controller branch May 26, 2023 09:02
@keptn-bot keptn-bot mentioned this pull request May 26, 2023
Merged
@keptn-bot keptn-bot mentioned this pull request Jun 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odubajDT odubajDT odubajDT approved these changes

@bacherfl bacherfl bacherfl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Keptn Lifecycle Toolkit
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor Task Controller to use multiple runtimes
3 participants
@RealAnna @bacherfl @odubajDT