Rework bert docstrings for progressive disclosure of complexity #843
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattdangerw
changed the title
jbischof
approved these changes
Mar 13, 2023
This reworks the full set of bert models and preprocessing layers for consistency, and in particular, progressive disclosure of complexity. In our example blocks, we will always lead with the simplest usages (e.g. from_preset()), and show more complex usages lower down.
mattdangerw
force-pushed
the
bert-docstring-rework
branch
from
a86b44c to
5121a58
Compare
This was referenced Mar 17, 2023
Merged
kanpuriyanawab
pushed a commit
to kanpuriyanawab/keras-nlp
that referenced
this pull request
Mar 26, 2023
This reworks the full set of bert models and preprocessing layers for consistency, and in particular, progressive disclosure of complexity. In our example blocks, we will always lead with the simplest usages (e.g. from_preset()), and show more complex usages lower down.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reworks the full set of bert models and preprocessing layers for consistency, and in particular, progressive disclosure of complexity.
In our example blocks, we will always lead with the simplest usages (e.g. from_preset()), and show more complex usages lower down.
Fixes #688 (I will open up contributed issues for other models when this looks ready)