Skip to content

Rework bart docstrings #994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 19, 2023
Merged

Rework bart docstrings #994

merged 1 commit into from
Apr 19, 2023

Conversation

mattdangerw
Copy link
Member

No description provided.

@mattdangerw mattdangerw changed the title Reword bart docstrings Rework bart docstrings Apr 19, 2023
@jbischof
Copy link
Contributor

@mattdangerw would you be able to add a description or link to an issue for these docstring PRs? Having trouble figuring out what we're fixing.

@mattdangerw
Copy link
Member Author

@jbischof sorry it's this one #867.

I'm just running down the list, and going to a uniform style for models contributors missed. This was the original PR you reviewed #843 (I'm verbatim replicating that style for these PRs).

jbischof
jbischof approved these changes Apr 19, 2023
View reviewed changes
Copy link
Contributor

@jbischof jbischof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mattdangerw mattdangerw merged commit 9ab0ecf into keras-team:master Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenmoneygithub chenmoneygithub Awaiting requested review from chenmoneygithub

1 more reviewer

@jbischof jbischof jbischof approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattdangerw @jbischof