Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gff_tigrinya_eritrea should use ti-ER for its BCP 47 tag #158

Closed
mcdurdin opened this issue Jan 24, 2018 · 5 comments · Fixed by #176
Closed

gff_tigrinya_eritrea should use ti-ER for its BCP 47 tag #158

mcdurdin opened this issue Jan 24, 2018 · 5 comments · Fixed by #176

Comments

@mcdurdin
Copy link
Member

Because this keyboard is distinct from gff_tigrinya_ethiopia, it should have the region in the keyboard BCP 47 tag

@DavidLRowe
Copy link
Contributor

@mcdurdin So, if I understand correctly, ti should change to ti-ER in .keyboard_info, and there should be an addition to the .kps file to add ti-ER as well.

@mcdurdin
Copy link
Member Author

mcdurdin commented Feb 1, 2018

@DavidLRowe, yes that is correct, although the change to the .kps is not strictly necessary until we start deployment of .kmp files to Android/iOS (soon).

@DavidLRowe
Copy link
Contributor

closed via #176

@mcdurdin
Copy link
Member Author

Small note: in terms of workflow, it's better to close an issue when the PR is merged. You can do this automatically by using certain keywords in a PR comment, for example "fixes #158"

@mcdurdin
Copy link
Member Author

I've updated the PR to show this -- you can hover over the word 'fixes' to see the action that will occur when the PR is merged :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants