Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gff_tigrinya_eritrea] add region to BCP47 tag in .keyboard_info #176

Merged
merged 1 commit into from
Mar 14, 2018
Merged

[gff_tigrinya_eritrea] add region to BCP47 tag in .keyboard_info #176

merged 1 commit into from
Mar 14, 2018

Conversation

DavidLRowe
Copy link
Contributor

@DavidLRowe DavidLRowe commented Feb 8, 2018 •
edited by mcdurdin
Loading

address issue (fixes #158)

LornaSIL
LornaSIL approved these changes Feb 8, 2018
View reviewed changes
Copy link
Contributor

@LornaSIL LornaSIL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcdurdin mcdurdin changed the title add region to BCP47 tag in .keyboard_info [gff_tigrinya_eritrea] add region to BCP47 tag in .keyboard_info Feb 9, 2018
@DavidLRowe DavidLRowe mentioned this pull request Feb 9, 2018
Closed
@LornaSIL LornaSIL merged commit 20270e3 into keymanapp:master Mar 14, 2018
@DavidLRowe DavidLRowe deleted the dlr_gff_tigrinya_eritrea branch June 7, 2018 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LornaSIL LornaSIL LornaSIL approved these changes

Assignees
No one assigned
Labels
enhancement keyboard ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gff_tigrinya_eritrea should use ti-ER for its BCP 47 tag
4 participants
@DavidLRowe @LornaSIL @mcdurdin @MakaraSok