Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Website: made header and sidebar sticky #2452

Closed
wants to merge 5 commits into from
Closed

Website: made header and sidebar sticky #2452

wants to merge 5 commits into from

Conversation

Vultraz
Copy link
Contributor

@Vultraz Vultraz commented Feb 29, 2020 •
edited
Loading

Resolves #1007.

@request-info
Copy link

request-info bot commented Feb 29, 2020

It looks like we could use some more details. Good titles and descriptions help us fix things faster. If you can provide more information please update this issue.

@changeset-bot
Copy link

changeset-bot bot commented Feb 29, 2020 •
edited
Loading

🦋 Changeset is good to go

Latest commit: a02abe2

We got this.

This PR includes changesets to release 1 package
Name Type
@keystonejs/website Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Vultraz Vultraz changed the title [WIP] Website nav sticky Website: made header and sidebar sticky Feb 29, 2020
@jesstelford
Copy link
Contributor

It'd be great to get a recording of this in action for both desktop and mobile

@Vultraz
Copy link
Contributor Author

Vultraz commented Feb 29, 2020

Mobile: https://share.icloud.com/photos/0TexepdTB5psQOk7xGNrMM-0Q

And on the desktop it looks just like in your render.

@MadeByMike
Copy link
Contributor

@jesstelford we have preview deploys ;) https://deploy-preview-2452--v5keystonejs.netlify.com/quick-start/

@MadeByMike
Copy link
Contributor

It looks like this has created a UI issue. There is no point in having a sticky menu if the it looks like the menu broken when you are further down the page.

capt

MadeByMike
MadeByMike suggested changes Mar 3, 2020
View reviewed changes
Copy link
Contributor

@MadeByMike MadeByMike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't think of any solution other than not making the menu sticky on mobile

@Vultraz
Copy link
Contributor Author

Vultraz commented Mar 3, 2020

Oh. Ok, that is not good. 🤔

@Vultraz Vultraz changed the title Website: made header and sidebar sticky [WIP] Website: made header and sidebar sticky Mar 3, 2020
@Vultraz
Copy link
Contributor Author

Vultraz commented Mar 5, 2020

@MadeByMike implemented your suggestion

@Vultraz Vultraz changed the title [WIP] Website: made header and sidebar sticky Website: made header and sidebar sticky Mar 5, 2020
@Vultraz Vultraz mentioned this pull request Mar 18, 2020
Merged
@Vultraz
Copy link
Contributor Author

Vultraz commented Mar 20, 2020

@MadeByMike @jesstelford is this good to go?

jesstelford
jesstelford approved these changes Mar 20, 2020
View reviewed changes
Copy link
Contributor

@jesstelford jesstelford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3 it!

@Vultraz Vultraz mentioned this pull request Mar 24, 2020
Merged
@Vultraz
Copy link
Contributor Author

Vultraz commented Mar 24, 2020 •
edited
Loading

#2579 seems to supersede this so I'm closing this.

@Vultraz Vultraz closed this Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MadeByMike MadeByMike MadeByMike requested changes

@jesstelford jesstelford jesstelford approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Docs] Make header sticky
3 participants
@Vultraz @jesstelford @MadeByMike