Fix test failures on Windows and older Perl #13
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Custom infix operators from Syntax::Operator::Is only work on Perl v5.38+. On older Perl versions, the module can be installed but the operator is not properly registered, causing syntax errors like "Bareword found where operator expected". Fixes CPAN Testers failure on Perl 5.22. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
On Windows, setting an environment variable to an empty string via putenv() actually deletes the variable. Using `!!0` (which becomes "") caused PERL_ASSERT_ENABLED to be deleted, making getenv() return NULL and keeping assertions enabled. Changed to `0` which becomes "0" string, a proper falsy value that persists in the environment. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Pull Request Test Coverage Report for Build 20005012405Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
kfly8
added a commit
that referenced
this pull request
Dec 8, 2025
Changelog diff is: diff --git a/Changes b/Changes index 960d9de..b9e7aba 100644 --- a/Changes +++ b/Changes @@ -2,6 +2,10 @@ Revision history for Perl extension Syntax-Keyword-Assert {{$NEXT}} +0.17 2025-12-08T13:44:46Z + - Add custom error message support #11 + - Fix test failures on Windows and older Perl #13 + 0.16 2024-12-18T09:01:18Z - Fixed `isa` operator #9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes minor improvements to the test suite for compatibility and correctness. The main changes are related to environment variable handling and Perl version requirements in test files.
Test environment and compatibility updates:
PERL_ASSERT_ENABLEDint/02_assert_disabled.tto use a simple0instead of!!0, ensuring clarity and correctness in disabling assertions.v5.38) tot/10-integration/Syntax-Operator-Is.tto ensure that custom infix operators are only tested on supported Perl versions.