Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTV-440 : Deprecate Autoparcel for ErroredBacking.kt #1569

Merged

Conversation

hadia
Copy link
Contributor

@hadia hadia commented Mar 21, 2022

📲 What

🤔 Why

  • Remove all references to the AutoParcel library in Models, eventually, we will be able to remove that dependency.

Story 📖

https://kickstarter.atlassian.net/browse/NTV-440

@hadia hadia requested a review from Arkariang March 21, 2022 15:25
@codecov
Copy link

codecov bot commented Mar 21, 2022

Codecov Report

Merging #1569 (51ca1fc) into master (f405811) will increase coverage by 0.01%.
The diff coverage is 88.33%.

@@             Coverage Diff              @@
##             master    #1569      +/-   ##
============================================
+ Coverage     76.48%   76.50%   +0.01%     
- Complexity     1560     1563       +3     
============================================
  Files           355      355              
  Lines         14729    14771      +42     
  Branches       1653     1661       +8     
============================================
+ Hits          11266    11300      +34     
  Misses         2587     2587              
- Partials        876      884       +8     
Impacted Files Coverage Δ
...main/java/com/kickstarter/models/ErroredBacking.kt 86.53% <86.53%> (-13.47%) ⬇️
...ickstarter/mock/factories/ErroredBackingFactory.kt 100.00% <100.00%> (ø)
...main/java/com/kickstarter/models/SurveyResponse.kt 89.74% <0.00%> (-1.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f405811...51ca1fc. Read the comment docs.

@hadia hadia marked this pull request as ready for review March 21, 2022 17:15
@hadia hadia requested a review from leighdouglas March 21, 2022 17:15
Copy link
Contributor

@Arkariang Arkariang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Tested it on production with my personal account 👍

@hadia hadia merged commit dc1a050 into master Mar 23, 2022
@hadia hadia deleted the hadia/NTV-440_Deprecate_Autoparcel_for_ErroredBacking.kt branch March 23, 2022 18:43
Arkariang added a commit that referenced this pull request Apr 6, 2022
…e/NTV-411-integrate-payment-sheet

* 'master' of github.com:kickstarter/android-oss: (22 commits)
  NTV-476 :Migrate AccessTokenEnvelope.java to kotlin and deprecate Autoparcel (#1592)
  NTV-474 :Migrate SignupBody.java to kotlin and deprecate Autoparcel (#1591)
  NTV-472 : Migrate ResetPasswordBody.java to kotlin and deprecate Autoparcel (#1590)
  NTV-436: Migrate Reftag.java to kotlin and deprecate Autoparcel (#1589)
  NTV-471 : Migrate RegisterWithFacebookBody.java to kotlin and deprecate Autoparcel (#1588)
  NTV-468 :Migrate CheckoutData.java to kotlin and deprecate Autoparcel (#1586)
  NTV-443 : Migrate LoginWithFacebookBody.java to kotlin and deprecate Autoparcel (#1585)
  NTV-465: Add audio parsing (#1584)
  NTV-437:Migrate RelativeDateTimeOptions to Kotlin and deprecate Autoparcel (#1580)
  NTV-438: Deprecate autoparcel for checkout (#1583)
  NTV-381: Migrate KSCurrency to kotlin and deprecate autoparcel (#1578)
  NTV-463: Crash during regression (#1582)
  [no-jira]: update dependencies (#1579)
  NTV-445 : Migrate ProjectNotificationBody.java to kotlin and deprecate Autoparcel (#1581)
  NTV-441  : Migrat Video.java to kotlin and deprecate Autoparcel (#1577)
  NTV-434 :Deprecate Autoparcel for ShippingRule.kt (#1576)
  NTV-456: Ktlint integration update (#1575)
  NTV-440 : Deprecate Autoparcel for ErroredBacking.kt (#1569)
  NTV-444 :Migrate MessageBody.java to kotlin and deprecate Autoparcel (#1570)
  Migrate CreatorDetails.java to kotlin and deprecate Autoparcel (#1571)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants