Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTV-465: Add audio parsing #1584

Merged
merged 11 commits into from Mar 29, 2022
Merged

Conversation

Arkariang
Copy link
Contributor

📲 What

the HTML parser can now identify HTML pieces like:

<div class="template asset" contenteditable="false" data-id="2236466"> 
 <figure> 
  <audio controls="controls" preload="none">
   <source src="https://dr0rfahizzuzj.cloudfront.net/assets/002/236/466/f17de99e2a9e76a4954418c16d963f9b_mp3.mp3?2015" type="audio/mp3">
   <source src="https://dr0rfahizzuzj.cloudfront.net/assets/002/236/466/f17de99e2a9e76a4954418c16d963f9b_aac.aac?2015" type="audio/aac">
   <source src="https://dr0rfahizzuzj.cloudfront.net/assets/002/236/466/f17de99e2a9e76a4954418c16d963f9b_ogg.ogg?2015" type="audio/ogg">
   <source src="https://dr0rfahizzuzj.cloudfront.net/assets/002/236/466/f17de99e2a9e76a4954418c16d963f9b_webm.webm?2015" type="audio/webm">
  </audio> 
 </figure> 
</div>
  • The Parser will output a AudioViewElement to the list of ViewElements

🤔 Why

  • Support audio pieces on Campaign Tab

👀 See

  • When loading the Campaign tab of a project take a look in logcat, you will see the AudioViewElements are present on the list with the source url recognized for "mp3" format

Screen Shot 2022-03-28 at 1 22 13 PM

| | |

📋 QA

Story 📖

NTV-465

@codecov
Copy link

codecov bot commented Mar 28, 2022

Codecov Report

Merging #1584 (29cb04d) into master (aff05bf) will decrease coverage by 0.01%.
The diff coverage is 47.36%.

❗ Current head 29cb04d differs from pull request most recent head 0a60dc9. Consider uploading reports for the commit 0a60dc9 to get more accurate results

@@             Coverage Diff              @@
##             master    #1584      +/-   ##
============================================
- Coverage     76.85%   76.83%   -0.02%     
- Complexity     1630     1631       +1     
============================================
  Files           356      356              
  Lines         15007    15021      +14     
  Branches       1691     1695       +4     
============================================
+ Hits          11533    11542       +9     
- Misses         2573     2576       +3     
- Partials        901      903       +2     
Impacted Files Coverage Δ
...viewmodels/projectpage/ProjectCampaignViewModel.kt 0.00% <0.00%> (ø)
...java/com/kickstarter/libs/htmlparser/ElementExt.kt 52.00% <50.00%> (-0.09%) ⬇️
...java/com/kickstarter/libs/htmlparser/HTMLModels.kt 94.23% <100.00%> (+0.61%) ⬆️
...java/com/kickstarter/libs/htmlparser/HTMLParser.kt 93.54% <100.00%> (+0.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aff05bf...0a60dc9. Read the comment docs.

@Arkariang Arkariang marked this pull request as ready for review March 29, 2022 19:45
Copy link
Contributor

@hadia hadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌😍

@Arkariang Arkariang merged commit f4f4b59 into master Mar 29, 2022
@Arkariang Arkariang deleted the imartin/NTV-465-add-audio-parsing branch March 29, 2022 22:04
Arkariang added a commit that referenced this pull request Apr 6, 2022
…e/NTV-411-integrate-payment-sheet

* 'master' of github.com:kickstarter/android-oss: (22 commits)
  NTV-476 :Migrate AccessTokenEnvelope.java to kotlin and deprecate Autoparcel (#1592)
  NTV-474 :Migrate SignupBody.java to kotlin and deprecate Autoparcel (#1591)
  NTV-472 : Migrate ResetPasswordBody.java to kotlin and deprecate Autoparcel (#1590)
  NTV-436: Migrate Reftag.java to kotlin and deprecate Autoparcel (#1589)
  NTV-471 : Migrate RegisterWithFacebookBody.java to kotlin and deprecate Autoparcel (#1588)
  NTV-468 :Migrate CheckoutData.java to kotlin and deprecate Autoparcel (#1586)
  NTV-443 : Migrate LoginWithFacebookBody.java to kotlin and deprecate Autoparcel (#1585)
  NTV-465: Add audio parsing (#1584)
  NTV-437:Migrate RelativeDateTimeOptions to Kotlin and deprecate Autoparcel (#1580)
  NTV-438: Deprecate autoparcel for checkout (#1583)
  NTV-381: Migrate KSCurrency to kotlin and deprecate autoparcel (#1578)
  NTV-463: Crash during regression (#1582)
  [no-jira]: update dependencies (#1579)
  NTV-445 : Migrate ProjectNotificationBody.java to kotlin and deprecate Autoparcel (#1581)
  NTV-441  : Migrat Video.java to kotlin and deprecate Autoparcel (#1577)
  NTV-434 :Deprecate Autoparcel for ShippingRule.kt (#1576)
  NTV-456: Ktlint integration update (#1575)
  NTV-440 : Deprecate Autoparcel for ErroredBacking.kt (#1569)
  NTV-444 :Migrate MessageBody.java to kotlin and deprecate Autoparcel (#1570)
  Migrate CreatorDetails.java to kotlin and deprecate Autoparcel (#1571)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants