Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTV-439 :Deprecate Autoparcel for CreatorDetails.kt #1571

Merged
merged 2 commits into from Mar 23, 2022

Conversation

hadia
Copy link
Contributor

@hadia hadia commented Mar 22, 2022

📲 What

🤔 Why

  • Remove all references to the AutoParcel library in Models, eventually, we will be able to remove that dependency.

👀 See

Chedk the Creator details in the ProjectOverviewViewModel mapping the right values for creator
image

https://www.kickstarter.com/projects/tequila/a-summer-dance-festival?ref=android_project_share
image

Story 📖

https://kickstarter.atlassian.net/browse/NTV-439

@hadia hadia added maintenance 🗜 migration Migration Java to Kotlin labels Mar 22, 2022
@hadia hadia marked this pull request as ready for review March 22, 2022 16:33
@codecov
Copy link

codecov bot commented Mar 22, 2022

Codecov Report

Merging #1571 (8af68f6) into master (b91f070) will increase coverage by 0.02%.
The diff coverage is 96.77%.

@@             Coverage Diff              @@
##             master    #1571      +/-   ##
============================================
+ Coverage     76.42%   76.44%   +0.02%     
- Complexity     1549     1555       +6     
============================================
  Files           355      355              
  Lines         14691    14713      +22     
  Branches       1649     1652       +3     
============================================
+ Hits          11227    11247      +20     
  Misses         2590     2590              
- Partials        874      876       +2     
Impacted Files Coverage Δ
...main/java/com/kickstarter/models/CreatorDetails.kt 96.29% <96.29%> (-3.71%) ⬇️
...ickstarter/mock/factories/CreatorDetailsFactory.kt 100.00% <100.00%> (ø)
...main/java/com/kickstarter/models/SurveyResponse.kt 89.74% <0.00%> (-1.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b91f070...8af68f6. Read the comment docs.

@hadia hadia merged commit 02f2ecd into master Mar 23, 2022
@hadia hadia deleted the hadia/NTV-439_Deprecate_Autoparcel_for_CreatorDetails branch March 23, 2022 16:42
Arkariang added a commit that referenced this pull request Apr 6, 2022
…e/NTV-411-integrate-payment-sheet

* 'master' of github.com:kickstarter/android-oss: (22 commits)
  NTV-476 :Migrate AccessTokenEnvelope.java to kotlin and deprecate Autoparcel (#1592)
  NTV-474 :Migrate SignupBody.java to kotlin and deprecate Autoparcel (#1591)
  NTV-472 : Migrate ResetPasswordBody.java to kotlin and deprecate Autoparcel (#1590)
  NTV-436: Migrate Reftag.java to kotlin and deprecate Autoparcel (#1589)
  NTV-471 : Migrate RegisterWithFacebookBody.java to kotlin and deprecate Autoparcel (#1588)
  NTV-468 :Migrate CheckoutData.java to kotlin and deprecate Autoparcel (#1586)
  NTV-443 : Migrate LoginWithFacebookBody.java to kotlin and deprecate Autoparcel (#1585)
  NTV-465: Add audio parsing (#1584)
  NTV-437:Migrate RelativeDateTimeOptions to Kotlin and deprecate Autoparcel (#1580)
  NTV-438: Deprecate autoparcel for checkout (#1583)
  NTV-381: Migrate KSCurrency to kotlin and deprecate autoparcel (#1578)
  NTV-463: Crash during regression (#1582)
  [no-jira]: update dependencies (#1579)
  NTV-445 : Migrate ProjectNotificationBody.java to kotlin and deprecate Autoparcel (#1581)
  NTV-441  : Migrat Video.java to kotlin and deprecate Autoparcel (#1577)
  NTV-434 :Deprecate Autoparcel for ShippingRule.kt (#1576)
  NTV-456: Ktlint integration update (#1575)
  NTV-440 : Deprecate Autoparcel for ErroredBacking.kt (#1569)
  NTV-444 :Migrate MessageBody.java to kotlin and deprecate Autoparcel (#1570)
  Migrate CreatorDetails.java to kotlin and deprecate Autoparcel (#1571)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance 🗜 migration Migration Java to Kotlin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants