Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTV-444 :Migrate MessageBody.java to kotlin and deprecate Autoparcel #1570

Conversation

hadia
Copy link
Contributor

@hadia hadia commented Mar 22, 2022

📲 What

🤔 Why

  • Remove all references to the AutoParcel library in Models, eventually, we will be able to remove that dependency.

👀 See

device-2022-03-22-162714.mp4

| --- | --- |
| | |

📋 QA

test sendMessage
Login with. native account and send message from messages list

Story 📖

https://kickstarter.atlassian.net/browse/NTV-444

@hadia hadia added maintenance 🗜 migration Migration Java to Kotlin labels Mar 22, 2022
@codecov
Copy link

codecov bot commented Mar 22, 2022

Codecov Report

Merging #1570 (f6db765) into master (b91f070) will increase coverage by 0.06%.
The diff coverage is 96.00%.

@@             Coverage Diff              @@
##             master    #1570      +/-   ##
============================================
+ Coverage     76.42%   76.48%   +0.06%     
- Complexity     1549     1559      +10     
============================================
  Files           355      355              
  Lines         14691    14729      +38     
  Branches       1649     1653       +4     
============================================
+ Hits          11227    11265      +38     
+ Misses         2590     2587       -3     
- Partials        874      877       +3     
Impacted Files Coverage Δ
...om/kickstarter/services/apirequests/MessageBody.kt 94.73% <94.73%> (ø)
...main/java/com/kickstarter/models/CreatorDetails.kt 96.29% <96.29%> (-3.71%) ⬇️
...ickstarter/mock/factories/CreatorDetailsFactory.kt 100.00% <100.00%> (ø)
...main/java/com/kickstarter/models/SurveyResponse.kt 89.74% <0.00%> (-1.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02f2ecd...f6db765. Read the comment docs.

@hadia hadia merged commit f405811 into master Mar 23, 2022
@hadia hadia deleted the hadia/NTV-444_Migrate_MessageBody_java_to_kotlin_and_deprecate_Autoparcel branch March 23, 2022 17:54
Arkariang added a commit that referenced this pull request Mar 23, 2022
…roid-oss into imartin/update-gradle-v2

* 'imartin/update-gradle-v2' of github.com:kickstarter/android-oss:
  NTV-444 :Migrate MessageBody.java to kotlin and deprecate Autoparcel (#1570)
Arkariang added a commit that referenced this pull request Apr 6, 2022
…e/NTV-411-integrate-payment-sheet

* 'master' of github.com:kickstarter/android-oss: (22 commits)
  NTV-476 :Migrate AccessTokenEnvelope.java to kotlin and deprecate Autoparcel (#1592)
  NTV-474 :Migrate SignupBody.java to kotlin and deprecate Autoparcel (#1591)
  NTV-472 : Migrate ResetPasswordBody.java to kotlin and deprecate Autoparcel (#1590)
  NTV-436: Migrate Reftag.java to kotlin and deprecate Autoparcel (#1589)
  NTV-471 : Migrate RegisterWithFacebookBody.java to kotlin and deprecate Autoparcel (#1588)
  NTV-468 :Migrate CheckoutData.java to kotlin and deprecate Autoparcel (#1586)
  NTV-443 : Migrate LoginWithFacebookBody.java to kotlin and deprecate Autoparcel (#1585)
  NTV-465: Add audio parsing (#1584)
  NTV-437:Migrate RelativeDateTimeOptions to Kotlin and deprecate Autoparcel (#1580)
  NTV-438: Deprecate autoparcel for checkout (#1583)
  NTV-381: Migrate KSCurrency to kotlin and deprecate autoparcel (#1578)
  NTV-463: Crash during regression (#1582)
  [no-jira]: update dependencies (#1579)
  NTV-445 : Migrate ProjectNotificationBody.java to kotlin and deprecate Autoparcel (#1581)
  NTV-441  : Migrat Video.java to kotlin and deprecate Autoparcel (#1577)
  NTV-434 :Deprecate Autoparcel for ShippingRule.kt (#1576)
  NTV-456: Ktlint integration update (#1575)
  NTV-440 : Deprecate Autoparcel for ErroredBacking.kt (#1569)
  NTV-444 :Migrate MessageBody.java to kotlin and deprecate Autoparcel (#1570)
  Migrate CreatorDetails.java to kotlin and deprecate Autoparcel (#1571)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance 🗜 migration Migration Java to Kotlin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants