Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTV-441 : Migrat Video.java to kotlin and deprecate Autoparcel #1577

Merged
merged 3 commits into from Mar 24, 2022

Conversation

hadia
Copy link
Contributor

@hadia hadia commented Mar 24, 2022

📲 What

🤔 Why

  • Remove all references to the AutoParcel library in Models, eventually, we will be able to remove that dependency.

👀 See

device-2022-03-24-152946.mp4

| --- | --- |
| | |

📋 QA

test videos for projects

Story 📖

https://kickstarter.atlassian.net/browse/NTV-441

@hadia hadia added the migration Migration Java to Kotlin label Mar 24, 2022
@codecov
Copy link

codecov bot commented Mar 24, 2022

Codecov Report

Merging #1577 (ba08d81) into master (dc1a050) will increase coverage by 0.09%.
The diff coverage is 96.42%.

@@             Coverage Diff              @@
##             master    #1577      +/-   ##
============================================
+ Coverage     76.50%   76.60%   +0.09%     
- Complexity     1564     1592      +28     
============================================
  Files           355      355              
  Lines         14771    14859      +88     
  Branches       1661     1672      +11     
============================================
+ Hits          11301    11383      +82     
+ Misses         2587     2586       -1     
- Partials        883      890       +7     
Impacted Files Coverage Δ
...va/com/kickstarter/libs/loadmore/ApolloPaginate.kt 71.29% <ø> (ø)
...m/kickstarter/libs/utils/ContextPropertyKeyName.kt 100.00% <ø> (ø)
...va/com/kickstarter/viewmodels/CommentsViewModel.kt 87.17% <ø> (ø)
...viewmodels/projectpage/ProjectCampaignViewModel.kt 0.00% <ø> (ø)
app/src/main/java/com/kickstarter/models/Video.kt 93.61% <93.61%> (ø)
...ter/services/apiresponses/ShippingRulesEnvelope.kt 94.73% <94.73%> (ø)
...c/main/java/com/kickstarter/models/ShippingRule.kt 94.11% <96.96%> (+10.78%) ⬆️
.../kickstarter/mock/factories/ShippingRuleFactory.kt 100.00% <100.00%> (ø)
...ter/mock/factories/ShippingRulesEnvelopeFactory.kt 100.00% <100.00%> (ø)
...ava/com/kickstarter/mock/factories/VideoFactory.kt 100.00% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8491449...ba08d81. Read the comment docs.

Copy link
Contributor

@Arkariang Arkariang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Arkariang Arkariang merged commit 6bf2052 into master Mar 24, 2022
@Arkariang Arkariang deleted the hadia/NTV-441_Migrato_Video branch March 24, 2022 17:54
Arkariang added a commit that referenced this pull request Apr 6, 2022
…e/NTV-411-integrate-payment-sheet

* 'master' of github.com:kickstarter/android-oss: (22 commits)
  NTV-476 :Migrate AccessTokenEnvelope.java to kotlin and deprecate Autoparcel (#1592)
  NTV-474 :Migrate SignupBody.java to kotlin and deprecate Autoparcel (#1591)
  NTV-472 : Migrate ResetPasswordBody.java to kotlin and deprecate Autoparcel (#1590)
  NTV-436: Migrate Reftag.java to kotlin and deprecate Autoparcel (#1589)
  NTV-471 : Migrate RegisterWithFacebookBody.java to kotlin and deprecate Autoparcel (#1588)
  NTV-468 :Migrate CheckoutData.java to kotlin and deprecate Autoparcel (#1586)
  NTV-443 : Migrate LoginWithFacebookBody.java to kotlin and deprecate Autoparcel (#1585)
  NTV-465: Add audio parsing (#1584)
  NTV-437:Migrate RelativeDateTimeOptions to Kotlin and deprecate Autoparcel (#1580)
  NTV-438: Deprecate autoparcel for checkout (#1583)
  NTV-381: Migrate KSCurrency to kotlin and deprecate autoparcel (#1578)
  NTV-463: Crash during regression (#1582)
  [no-jira]: update dependencies (#1579)
  NTV-445 : Migrate ProjectNotificationBody.java to kotlin and deprecate Autoparcel (#1581)
  NTV-441  : Migrat Video.java to kotlin and deprecate Autoparcel (#1577)
  NTV-434 :Deprecate Autoparcel for ShippingRule.kt (#1576)
  NTV-456: Ktlint integration update (#1575)
  NTV-440 : Deprecate Autoparcel for ErroredBacking.kt (#1569)
  NTV-444 :Migrate MessageBody.java to kotlin and deprecate Autoparcel (#1570)
  Migrate CreatorDetails.java to kotlin and deprecate Autoparcel (#1571)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
migration Migration Java to Kotlin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants