Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NTV-445 : Migrate ProjectNotificationBody.java to kotlin and deprecate Autoparcel #1581

Merged
merged 2 commits into from Mar 25, 2022
Merged

NTV-445 : Migrate ProjectNotificationBody.java to kotlin and deprecate Autoparcel #1581

merged 2 commits into from Mar 25, 2022

Conversation

hadia
Copy link
Contributor

@hadia hadia commented Mar 25, 2022 •
edited

📲 What

🤔 Why

  • Remove all references to the AutoParcel library in Models, eventually, we will be able to remove that dependency.

👀 See

Screen Shot 2022-03-25 at 8 10 43 PM

| --- | --- |
| | |

📋 QA

test setting for project Notifications

device-2022-03-25-201415.mp4

Story 📖

https://kickstarter.atlassian.net/browse/NTV-445

@hadia hadia requested a review from Arkariang March 25, 2022 17:56
@hadia hadia added the migration Migration Java to Kotlin label Mar 25, 2022
@hadia hadia requested a review from leighdouglas March 25, 2022 17:57
@codecov
Copy link

codecov bot commented Mar 25, 2022 •
edited

Codecov Report

Merging #1581 (7c89ea2) into master (6bf2052) will increase coverage by 0.04%.
The diff coverage is 96.15%.

@@             Coverage Diff              @@
##             master    #1581      +/-   ##
============================================
+ Coverage     76.60%   76.65%   +0.04%     
- Complexity     1592     1599       +7     
============================================
  Files           355      355              
  Lines         14859    14882      +23     
  Branches       1672     1675       +3     
============================================
+ Hits          11383    11408      +25     
+ Misses         2586     2583       -3     
- Partials        890      891       +1
Impacted Files Coverage Δ
...er/services/apirequests/ProjectNotificationBody.kt 96.15% <96.15%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bf2052...7c89ea2. Read the comment docs.

Arkariang
Arkariang approved these changes Mar 25, 2022
View reviewed changes
Copy link
Contributor

@Arkariang Arkariang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@hadia hadia merged commit 8ac6ef3 into master Mar 25, 2022
@hadia hadia deleted the hadia/NTV-445_Migrate_ProjectNotificationBody branch March 25, 2022 19:01
Arkariang added a commit that referenced this pull request Mar 28, 2022
@Arkariang
Merge branch 'master' of github.com:kickstarter/android-oss into rele…
16b6164 
…ase-3.1.0

* 'master' of github.com:kickstarter/android-oss:
  NTV-463: Crash during regression (#1582)
  [no-jira]: update dependencies (#1579)
  NTV-445 : Migrate ProjectNotificationBody.java to kotlin and deprecate Autoparcel (#1581)
Arkariang added a commit that referenced this pull request Apr 6, 2022
@Arkariang
Merge branch 'master' of github.com:kickstarter/android-oss into spik…
8afc2c6 
…e/NTV-411-integrate-payment-sheet

* 'master' of github.com:kickstarter/android-oss: (22 commits)
  NTV-476 :Migrate AccessTokenEnvelope.java to kotlin and deprecate Autoparcel (#1592)
  NTV-474 :Migrate SignupBody.java to kotlin and deprecate Autoparcel (#1591)
  NTV-472 : Migrate ResetPasswordBody.java to kotlin and deprecate Autoparcel (#1590)
  NTV-436: Migrate Reftag.java to kotlin and deprecate Autoparcel (#1589)
  NTV-471 : Migrate RegisterWithFacebookBody.java to kotlin and deprecate Autoparcel (#1588)
  NTV-468 :Migrate CheckoutData.java to kotlin and deprecate Autoparcel (#1586)
  NTV-443 : Migrate LoginWithFacebookBody.java to kotlin and deprecate Autoparcel (#1585)
  NTV-465: Add audio parsing (#1584)
  NTV-437:Migrate RelativeDateTimeOptions to Kotlin and deprecate Autoparcel (#1580)
  NTV-438: Deprecate autoparcel for checkout (#1583)
  NTV-381: Migrate KSCurrency to kotlin and deprecate autoparcel (#1578)
  NTV-463: Crash during regression (#1582)
  [no-jira]: update dependencies (#1579)
  NTV-445 : Migrate ProjectNotificationBody.java to kotlin and deprecate Autoparcel (#1581)
  NTV-441  : Migrat Video.java to kotlin and deprecate Autoparcel (#1577)
  NTV-434 :Deprecate Autoparcel for ShippingRule.kt (#1576)
  NTV-456: Ktlint integration update (#1575)
  NTV-440 : Deprecate Autoparcel for ErroredBacking.kt (#1569)
  NTV-444 :Migrate MessageBody.java to kotlin and deprecate Autoparcel (#1570)
  Migrate CreatorDetails.java to kotlin and deprecate Autoparcel (#1571)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arkariang Arkariang Arkariang approved these changes

@leighdouglas leighdouglas Awaiting requested review from leighdouglas

Assignees
No one assigned
Labels
migration Migration Java to Kotlin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hadia @Arkariang