[馃洅] NT-1105 Kickstarter is not a store redesign #823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added click listener to whole accountability container - Using new accountability copy ## `PledgeFragmentViewModel` - Removed output `deliveryDividerIsGone` since the divider is no longer present - Renamed output `deliverySectionIsGone` to `rewardSummaryIsGone` - Updated tests ## XML - Removed `accountability` into its own layout `fragment_pledge_section_accountability` - Removed parent `LinearLayout` from `fragment_pledge_section_reward_summary` since there was only 1 child ## Resources - Added `ic_not_a_store.xml` icon - Added untranslated `Its_a_way_to_bring_creative_projects_to_life_Learn_more_about_accountability` string
jgsamudio
approved these changes
Apr 6, 2020
eoji
added a commit
that referenced
this pull request
Apr 20, 2020
* [馃Χ馃従] NT-1104 Add Pledge screen footer (#817) * [猬嘳 NT-1120 Vertical payment methods in Pledge screen (#821) * [馃敤] NT-1121 Stored cards redesign (#822) * [馃洅] NT-1105 Kickstarter is not a store redesign (#823) * [馃挸] NT-1122 Initial card selection (#824) * [鈴砞 NT-1124 Loading state for payment methods (#825) * [鉃昡 NT-1125 New card CTA (#828) * [馃挸] NT-1123 Last four digits copy (#826) * [馃挸] NT-1123 Card not allowed copy (#827) * [馃帹] NT-1111 Adding 2 buttons in the new pledge footer (#830) * [馃攲] NT-1129 Adding progress state for pledging (#831) * [馃棧] NT-1126 Payment methods a11y (#829) * [馃懛馃従鈥嶁檧锔廬 NT-1128 Moved continue button in Pledge screen to footer (#833) * [鈿狅笍 ] NT-1131 Pledge error Toasts (#832) * [鈵 NT-1127 Removing Update pledge button (#834) * [馃摑] NT-1130 Pledge button CTA (#835) * [鉁匽 NT-1133 Enabling pledge button only when all fields are valid (#836)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃摬 What
New accountability design.
馃 Why
Looks more better.
馃洜 How
PledgeFragmentPledgeFragmentViewModeldeliveryDividerIsGonesince the divider is no longer presentdeliverySectionIsGonetorewardSummaryIsGoneXML
accountabilityinto its own layoutfragment_pledge_section_accountabilityLinearLayoutfromfragment_pledge_section_reward_summarysince there was only 1 childResources
ic_not_a_store.xmliconIts_a_way_to_bring_creative_projects_to_life_Learn_more_about_accountabilitystring馃憖 See
馃搵 QA
Smash that accountability container.
Story 馃摉
NT-1105