[💳] NT-1122 Initial card selection #824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgsamudio
reviewed
Apr 8, 2020
| val defaultIndex = 0 | ||
| val backingPaymentSourceIndex = storedCards.indexOfFirst { it.id() == project.backing()?.paymentSource()?.id() } | ||
| return when { | ||
| backingPaymentSourceIndex != -1 -> Pair(storedCards[backingPaymentSourceIndex], backingPaymentSourceIndex) |
There was a problem hiding this comment.
Is the backingPaymentSourceIndex set to -1 if indexOfFirst doesn't find something?
There was a problem hiding this comment.
Yeah, that's what indexOfFirst returns https://kotlinlang.org/api/latest/jvm/stdlib/kotlin.collections/index-of-first.html
jgsamudio
approved these changes
Apr 8, 2020
eoji
added a commit
that referenced
this pull request
Apr 20, 2020
* [🦶🏾] NT-1104 Add Pledge screen footer (#817) * [⬇] NT-1120 Vertical payment methods in Pledge screen (#821) * [🔨] NT-1121 Stored cards redesign (#822) * [🛒] NT-1105 Kickstarter is not a store redesign (#823) * [💳] NT-1122 Initial card selection (#824) * [⏳] NT-1124 Loading state for payment methods (#825) * [➕] NT-1125 New card CTA (#828) * [💳] NT-1123 Last four digits copy (#826) * [💳] NT-1123 Card not allowed copy (#827) * [🎨] NT-1111 Adding 2 buttons in the new pledge footer (#830) * [🔌] NT-1129 Adding progress state for pledging (#831) * [🗣] NT-1126 Payment methods a11y (#829) * [👷🏾♀️] NT-1128 Moved continue button in Pledge screen to footer (#833) * [⚠️ ] NT-1131 Pledge error Toasts (#832) * [␡] NT-1127 Removing Update pledge button (#834) * [📝] NT-1130 Pledge button CTA (#835) * [✅] NT-1133 Enabling pledge button only when all fields are valid (#836)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Automatically selecting a logged in user's first card or the card used to pledge.
🤔 Why
To make it easier for users to pledge.
🛠 How
pledge_footer_pledge_buttonnow accepts clicks (meaning you can actually pledge and update your payment method with it)Update Pledgebutton will be removed in another PR to keep this one small)RewardCardUnselectedViewHolder
Delegate.selectCardButtonClickedtocardSelectedthat takes in theStoredCardalong with itspositionnotifyDelegateCardSelectedthat emits a<Pair<StoredCard, Int>>of the selected card and its positionPledgeFragmentViewModelpledgeButtonClickedno longer takes in the card IDStringselectCardButtonClickedis nowcardSelectedthat takes in aStoredCardand its positioninitialCardSelectionmethod to figure out what the initial selected card should beTestDatadata class to help set up situations like updating a pledge with or without shippingsetUpBackedShippableRewardTestDataandsetUpBackedNoRewardTestDataand used them to clean up a few testsDeletions
BaseRewardCardViewHolderViewModelidoutput since it's no longer usedRewardLoadingCardViewHolderViewModel👀 See
📋 QA
Smash that pledge button.
Story 📖
NT-1122