[⚠️] NT-1131 Pledge error Toasts #832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 🆕 shiny helper function to show error `Toast`s ## `PledgeFragment` - Using shiny 🆕 aforementioned helper function to show pledge errors ## XML - Added `ic_icon_alert.xml` - Created a new layout for the error `Toast`s `toast_error.xml` - Added `Alert` a11y string
colleenmacd
approved these changes
Apr 9, 2020
Scollaco
approved these changes
Apr 10, 2020
|
|
||
| fun showErrorToast(applicationContext: Context, root: ViewGroup, message: String) { | ||
| val layout: ViewGroup = LayoutInflater.from(applicationContext).inflate(R.layout.toast_error, root, false) as ViewGroup | ||
| val text: TextView = layout.findViewById(R.id.toast_text_view) |
There was a problem hiding this comment.
Maybe textView would be a better name, instead of simply text.
There was a problem hiding this comment.
I stole this code lol https://developer.android.com/guide/topics/ui/notifiers/toasts#CustomToastView
| android:id="@+id/toast_text_view" | ||
| style="@style/Subheadline" | ||
| android:layout_width="0dp" | ||
| android:layout_height="wrap_content" |
There was a problem hiding this comment.
I tried changing the traversal order by setting android:accessibilityTraversalAfter="@id/toast_icon here, but it didn't work either 🤷🏻♂️ Maybe this value is being overridden somewhere?
There was a problem hiding this comment.
Yeah, like the dang Toast is doing something weird. I know that traversal is based on the top most view but even setting the size of the icon to the size of the container didn't work 😒
eoji
added a commit
that referenced
this pull request
Apr 20, 2020
* [🦶🏾] NT-1104 Add Pledge screen footer (#817) * [⬇] NT-1120 Vertical payment methods in Pledge screen (#821) * [🔨] NT-1121 Stored cards redesign (#822) * [🛒] NT-1105 Kickstarter is not a store redesign (#823) * [💳] NT-1122 Initial card selection (#824) * [⏳] NT-1124 Loading state for payment methods (#825) * [➕] NT-1125 New card CTA (#828) * [💳] NT-1123 Last four digits copy (#826) * [💳] NT-1123 Card not allowed copy (#827) * [🎨] NT-1111 Adding 2 buttons in the new pledge footer (#830) * [🔌] NT-1129 Adding progress state for pledging (#831) * [🗣] NT-1126 Payment methods a11y (#829) * [👷🏾♀️] NT-1128 Moved continue button in Pledge screen to footer (#833) * [⚠️ ] NT-1131 Pledge error Toasts (#832) * [␡] NT-1127 Removing Update pledge button (#834) * [📝] NT-1130 Pledge button CTA (#835) * [✅] NT-1133 Enabling pledge button only when all fields are valid (#836)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Beautiful new error
Toastin the pledge screen🤔 Why
The footer hid the old
Snackbar🛠 How
ToastExtToastPledgeFragmentXML
ic_icon_alert.xmlToaststoast_error.xmlAlerta11y string👀 See
📋 QA
IDK what kind of shenanigans TalkBack is on but it refuses to read the
Alerticon first ಠ_ಠStory 📖
NT-1131