Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[🗣] NT-1126 Payment methods a11y #829

Merged
merged 1 commit into from
Apr 10, 2020
Merged

[🗣] NT-1126 Payment methods a11y #829

merged 1 commit into from
Apr 10, 2020

Conversation

eoji
Copy link
Contributor

@eoji eoji commented Apr 8, 2020 •
edited by jira bot

📲 What

Payment methods a11y

🤔 Why

So users who use voice assistance know which card is selected

🛠 How

  • Added new strings Selected_card and Select this card
    • Added content descriptions for select state icons in item_reward_selected_card and item_reward_unselected_card

👀 See

Selected ✅ Unselected ☑️
screenshot-2020-04-08_171301 screenshot-2020-04-08_171310

📋 QA

Turn on TalkBack 🗣

Story 📖

NT-1126

@eoji
Added content descriptions for select state icons in `item_reward_sel…
868df79 
…ected_card` and `item_reward_unselected_card`
@eoji eoji requested a review from a team April 8, 2020 21:18
Scollaco
Scollaco approved these changes Apr 10, 2020
View reviewed changes
Copy link
Contributor

@Scollaco Scollaco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks (sounds) good! 🚢

@eoji eoji merged commit ce3dfac into NT-1103 Apr 10, 2020
@eoji eoji deleted the NT-1126 branch April 10, 2020 21:19
@eoji eoji mentioned this pull request Apr 13, 2020
Merged
eoji added a commit that referenced this pull request Apr 20, 2020
@eoji
[🎨] NT-1103 Pledge screen redesign (#837)
2553140 
* [🦶🏾] NT-1104 Add Pledge screen footer (#817)
* [⬇] NT-1120 Vertical payment methods in Pledge screen (#821)
* [🔨] NT-1121 Stored cards redesign (#822)
* [🛒] NT-1105 Kickstarter is not a store redesign (#823)
* [💳] NT-1122 Initial card selection (#824)
* [⏳] NT-1124 Loading state for payment methods (#825)
* [➕] NT-1125 New card CTA (#828)
* [💳] NT-1123 Last four digits copy (#826)
* [💳] NT-1123 Card not allowed copy (#827)
* [🎨] NT-1111 Adding 2 buttons in the new pledge footer (#830)
* [🔌] NT-1129 Adding progress state for pledging (#831)
* [🗣] NT-1126 Payment methods a11y (#829)
* [👷🏾‍♀️] NT-1128 Moved continue button in Pledge screen to footer (#833)
* [⚠️] NT-1131 Pledge error Toasts (#832)
* [␡] NT-1127 Removing Update pledge button (#834)
* [📝] NT-1130 Pledge button CTA (#835)
* [✅] NT-1133 Enabling pledge button only when all fields are valid (#836)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Scollaco Scollaco Scollaco approved these changes

Assignees
No one assigned
Labels
a11y ♿️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eoji @Scollaco