Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[馃挸] NT-1123 Last four digits copy #826

Merged
merged 1 commit into from
Apr 9, 2020
Merged

[馃挸] NT-1123 Last four digits copy #826

merged 1 commit into from
Apr 9, 2020

Conversation

eoji
Copy link
Contributor

@eoji eoji commented Apr 8, 2020

馃摬 What

Updating copy of payment methods' last four digits.

馃 Why

馃啎 copy

馃洜 How

Updating payment methods' last four digits copy.

  • Added template string payment_method_last_four
    • Used in BackingFragment, RewardCardSelectedViewHolder, and RewardCardUnselectedViewHolder
  • Updated StoredCard.DATE_FORMAT because I noticed a bug where the dates were displaying strangely

馃憖 See

View/Manage pledge screen Pledge screen Bug 馃悶
screenshot-2020-04-08_135848 screenshot-2020-04-08_135859 screenshot-2020-04-08_135622

馃搵 QA

View/Manage a pledge, back a project

Story 馃摉

NT-1123

- Added template string `payment_method_last_four`
  - Used in `BackingFragment`, `RewardCardSelectedViewHolder`, and `RewardCardUnselectedViewHolder`
- Updated `StoredCard.DATE_FORMAT` because I noticed a bug where the dates were displaying strangely
@eoji eoji requested a review from a team April 8, 2020 19:16
Copy link

@ifbarrera ifbarrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@eoji eoji merged commit 4328961 into NT-1103 Apr 9, 2020
@eoji eoji deleted the NT-1123-last4 branch April 9, 2020 18:38
eoji added a commit that referenced this pull request Apr 20, 2020
* [馃Χ馃従] NT-1104 Add Pledge screen footer (#817)
* [猬嘳 NT-1120 Vertical payment methods in Pledge screen (#821)
* [馃敤] NT-1121 Stored cards redesign (#822)
* [馃洅] NT-1105 Kickstarter is not a store redesign (#823)
* [馃挸] NT-1122 Initial card selection (#824)
* [鈴砞 NT-1124 Loading state for payment methods (#825)
* [鉃昡 NT-1125 New card CTA (#828)
* [馃挸] NT-1123 Last four digits copy (#826)
* [馃挸] NT-1123 Card not allowed copy (#827)
* [馃帹] NT-1111 Adding 2 buttons in the new pledge footer (#830)
* [馃攲] NT-1129 Adding progress state for pledging (#831)
* [馃棧] NT-1126 Payment methods a11y (#829)
* [馃懛馃従鈥嶁檧锔廬 NT-1128 Moved continue button in Pledge screen to footer (#833)
* [鈿狅笍] NT-1131 Pledge error Toasts (#832)
* [鈵 NT-1127 Removing Update pledge button (#834)
* [馃摑] NT-1130 Pledge button CTA (#835)
* [鉁匽 NT-1133 Enabling pledge button only when all fields are valid (#836)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants