Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[✅] NT-1133 Enabling pledge button only when all fields are valid #836

Merged
merged 3 commits into from
Apr 13, 2020
Merged

[✅] NT-1133 Enabling pledge button only when all fields are valid #836

merged 3 commits into from
Apr 13, 2020

Conversation

eoji
Copy link
Contributor

@eoji eoji commented Apr 10, 2020 •
edited

📲 What

Enabling pledge button only when shipping rules have loaded, the pledge amount is valid, and a card has been selected.

🤔 Why

It's nice.

🛠 How

  • pledgeButtonIsEnabled only emits when the pledge total is valid and a card has been selected
  • Tests
    • Made a helper method apolloClientWithStoredCards to clean up.

bugs

  • Fixed bug where stored cards were fetched 5 times instead of 1
  • Fixed bug where pledgeButtonIsGone was changing the wrong view

👀 See

Without shipping With shipping
device-2020-04-10-185215 2020-04-10 18_56_11 device-2020-04-10-185558 2020-04-10 19_02_03

📋 QA

Pledge™

Story 📖

NT-1133

@eoji
Not enabling the pledge button until a payment method has been selected.
1bfb753 
Updated tests that broke because international projects don't accept Discover.
@eoji
Merge branch 'NT-1103' into NT-1133
4042a1f 
# Conflicts:
#	app/src/main/java/com/kickstarter/viewmodels/PledgeFragmentViewModel.kt
@eoji
fixes bug where output changed the wrong view
e712b83
@eoji eoji requested a review from a team April 10, 2020 23:10
@eoji eoji merged commit 263a79d into NT-1103 Apr 13, 2020
@eoji eoji deleted the NT-1133 branch April 13, 2020 15:27
@eoji eoji mentioned this pull request Apr 13, 2020
Merged
eoji added a commit that referenced this pull request Apr 20, 2020
@eoji
[🎨] NT-1103 Pledge screen redesign (#837)
2553140 
* [🦶🏾] NT-1104 Add Pledge screen footer (#817)
* [⬇] NT-1120 Vertical payment methods in Pledge screen (#821)
* [🔨] NT-1121 Stored cards redesign (#822)
* [🛒] NT-1105 Kickstarter is not a store redesign (#823)
* [💳] NT-1122 Initial card selection (#824)
* [⏳] NT-1124 Loading state for payment methods (#825)
* [➕] NT-1125 New card CTA (#828)
* [💳] NT-1123 Last four digits copy (#826)
* [💳] NT-1123 Card not allowed copy (#827)
* [🎨] NT-1111 Adding 2 buttons in the new pledge footer (#830)
* [🔌] NT-1129 Adding progress state for pledging (#831)
* [🗣] NT-1126 Payment methods a11y (#829)
* [👷🏾‍♀️] NT-1128 Moved continue button in Pledge screen to footer (#833)
* [⚠️] NT-1131 Pledge error Toasts (#832)
* [␡] NT-1127 Removing Update pledge button (#834)
* [📝] NT-1130 Pledge button CTA (#835)
* [✅] NT-1133 Enabling pledge button only when all fields are valid (#836)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yatriks yatriks yatriks approved these changes

Assignees
No one assigned
Labels
bug 🐛 feature ✨
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eoji @yatriks