This repository was archived by the owner on Dec 29, 2021. It is now read-only.
Increase context on failures #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stdout and stderr will now be shown when the exit code is an unexpected value. This will serve to provide additional context for the developer without them having to fire up a debugger or manually reproduce the failure condition.
killercup
approved these changes
Sep 27, 2017
Collaborator
killercup
left a comment
killercup
left a comment
There was a problem hiding this comment.
LGTM
This reminds me: We should add tests for this.
| self.matches_exact(&observed) | ||
| }; | ||
| result.map_err(|e| self.kind.map_err(e, cmd)) | ||
| result.map_err(|e| super::errors::ErrorKind::OutputMismatch(cmd.to_vec(), e, self.kind))?; |
Collaborator
There was a problem hiding this comment.
Isnt't ErrorKind in scope from the glob import?
Collaborator
Author
There was a problem hiding this comment.
The ErrorKind that is in scope is from self, not super.
Collaborator
Author
|
bors: r+ |
Contributor
Build succeeded |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also includes a minor refactor to simplify
output.rs.