Skip to content

minor fixes from dev #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 22, 2023
Merged

minor fixes from dev #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
760ab41
minor fix
maximiliani Aug 22, 2023
a5148bd
minor fix
maximiliani Aug 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/display-magic/display-magic.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,7 +360,7 @@ export class DisplayMagic {
levelOfSubcomponents={this.levelOfSubcomponents}
currentLevelOfSubcomponents={this.currentLevelOfSubcomponents + 1}
amountOfItems={this.amountOfItems}
doNOTShowSubcomponents={true}
hideSubcomponents={true}
settings={this.settings} />
: !this.hideSubcomponents && this.currentLevelOfSubcomponents === this.levelOfSubcomponents && !value.doNOTFold && !value.defaultToText
? <display-magic value={value.value}
Expand Down
2 changes: 1 addition & 1 deletion src/components/display-magic/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
| ----------------------------- | -------------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ | --------- | ----------- |
| `amountOfItems` | `amount-of-items` | The number of items to show in the table per page. Defaults to 10. (optional) | `number` | `10` |
| `currentLevelOfSubcomponents` | `current-level-of-subcomponents` | The current level of subcomponents. Defaults to 0. (optional) | `number` | `0` |
| `doNOTShowSubcomponents` | `do-n-o-t-show-subcomponents` | Determines whether subcomponents should generally be shown or not. If set to true, the component won't show any subcomponents. If not set, the component will show subcomponents, if the current level of subcomponents is not the total level of subcomponents or greater. (optional) | `boolean` | `undefined` |
| `hideSubcomponents` | `hide-subcomponents` | Determines whether subcomponents should generally be shown or not. If set to true, the component won't show any subcomponents. If not set, the component will show subcomponents if the current level of subcomponents is not the total level of subcomponents or greater. (optional) | `boolean` | `undefined` |
| `levelOfSubcomponents` | `level-of-subcomponents` | The total number of levels of subcomponents to show. Defaults to 1. (optional) | `number` | `1` |
| `openByDefault` | `open-by-default` | Determines whether the component is open or not by default. (optional) | `boolean` | `undefined` |
| `settings` | `settings` | A stringified JSON object containing settings for this component. The resulting object is passed to every subcomponent, so that every component has the same settings. Values and the according type are defined by the components themselves. (optional) Schema: ```typescript { type: string, values: { name: string, value: any }[] }[] ``` | `string` | `undefined` |
Expand Down
4 changes: 2 additions & 2 deletions vscode-data.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@
"description": "The current level of subcomponents.\nDefaults to 0.\n(optional)"
},
{
"name": "do-n-o-t-show-subcomponents",
"description": "Determines whether subcomponents should generally be shown or not.\nIf set to true, the component won't show any subcomponents.\nIf not set, the component will show subcomponents, if the current level of subcomponents is not the total level of subcomponents or greater.\n(optional)"
"name": "hide-subcomponents",
"description": "Determines whether subcomponents should generally be shown or not.\nIf set to true, the component won't show any subcomponents.\nIf not set, the component will show subcomponents\nif the current level of subcomponents is not the total level of subcomponents or greater.\n(optional)"
},
{
"name": "level-of-subcomponents",
Expand Down